[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=403107&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403107
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 19:40
Start Date: 13/Mar/20 19:40
Worklog Time Spent: 10m
Work Description: robertwb commented on issue #11067: [BEAM-9136]Add
licenses for dependencies
URL: https://github.com/apache/beam/pull/11067#issuecomment-598882830
In general, it's preferable to avoid checking in script-created files,
preferring instead to create them on demand at build time. (There are
exceptions, e.g. bootstrapping and/or difficult to obtain build tools, but I
don't think that applies here.)
As another principle, it's preferable, where possible, to enforce
correctness of the repository state before things get committed/merged (e.g. at
pre-commit time), rather than have a separate, asynchronous, external process
to try to fix things up after the fact.
Perhaps it's worth expanding the design doc on how we could do this?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 403107)
Time Spent: 2h 20m (was: 2h 10m)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 2h 20m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
