[
https://issues.apache.org/jira/browse/BEAM-8374?focusedWorklogId=403250&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-403250
]
ASF GitHub Bot logged work on BEAM-8374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Mar/20 22:55
Start Date: 13/Mar/20 22:55
Worklog Time Spent: 10m
Work Description: jfarr commented on pull request #9758: [BEAM-8374]
Enable returning missing PublishResult fields in SnsIO.Write
URL: https://github.com/apache/beam/pull/9758#discussion_r392519864
##########
File path:
sdks/java/io/amazon-web-services/src/main/java/org/apache/beam/sdk/io/aws/sns/SnsCoderProviderRegistrar.java
##########
@@ -32,6 +32,7 @@
@Override
public List<CoderProvider> getCoderProviders() {
return ImmutableList.of(
- CoderProviders.forCoder(TypeDescriptor.of(PublishResult.class),
PublishResultCoder.of()));
+ CoderProviders.forCoder(
+ TypeDescriptor.of(PublishResult.class),
PublishResultCoders.defaultPublishResult()));
Review comment:
It's sort of the same reason as above, PublishResultCoders is a factory for
creating several different coder implementations so the factory methods have
different names to indicate which one. I could rename this method to `of()` but
since we are introducing new behavior I wanted to make it very clear that this
is the default, or existing, behavior. Also I'm not sure if it makes sense to
have a method called `of()` on the factory not on the coder itself.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 403250)
Time Spent: 9.5h (was: 9h 20m)
> PublishResult returned by SnsIO is missing sdkResponseMetadata and
> sdkHttpMetadata
> ----------------------------------------------------------------------------------
>
> Key: BEAM-8374
> URL: https://issues.apache.org/jira/browse/BEAM-8374
> Project: Beam
> Issue Type: Bug
> Components: io-java-aws
> Affects Versions: 2.13.0, 2.14.0, 2.15.0
> Reporter: Jonothan Farr
> Assignee: Jonothan Farr
> Priority: Minor
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Currently the PublishResultCoder in SnsIO only serializes the messageId field
> so the PublishResult returned by Beam returns null for
> getSdkResponseMetadata() and getSdkHttpMetadata(). This makes it impossible
> to check the HTTP status for errors, which is necessary since this is not
> handled in SnsIO.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
