[
https://issues.apache.org/jira/browse/BEAM-9279?focusedWorklogId=405626&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405626
]
ASF GitHub Bot logged work on BEAM-9279:
----------------------------------------
Author: ASF GitHub Bot
Created on: 18/Mar/20 17:53
Start Date: 18/Mar/20 17:53
Worklog Time Spent: 10m
Work Description: aromanenko-dev commented on pull request #10815:
[BEAM-9279] Make HBase.ReadAll based on Reads instead of HBaseQuery
URL: https://github.com/apache/beam/pull/10815#discussion_r394512504
##########
File path:
sdks/java/io/hbase/src/main/java/org/apache/beam/sdk/io/hbase/HBaseIO.java
##########
@@ -173,33 +182,33 @@ public static Read read() {
/** Reads from the HBase instance indicated by the* given configuration. */
public Read withConfiguration(Configuration configuration) {
checkArgument(configuration != null, "configuration can not be null");
- return new Read(new SerializableConfiguration(configuration), tableId,
serializableScan);
+ return new Read(new Configuration(configuration), tableId, scan);
}
/** Reads from the specified table. */
public Read withTableId(String tableId) {
checkArgument(tableId != null, "tableIdcan not be null");
Review comment:
typo "tableIdcan"
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 405626)
Time Spent: 1h 20m (was: 1h 10m)
> Make HBase.ReadAll based on Reads instead of HBaseQuery
> -------------------------------------------------------
>
> Key: BEAM-9279
> URL: https://issues.apache.org/jira/browse/BEAM-9279
> Project: Beam
> Issue Type: Improvement
> Components: io-java-hbase
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> HBaseIO support for SplittableDoFn introduced a new request type HBaseQuery,
> however the attributes defined in that class are already available in
> HBase.Read. Allowing users to define pipelines based on HBaseIO.Read allows
> to create pipelines that can read from multiple clusters because the
> Configuration now is part of the request object.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
