[
https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=405882&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-405882
]
ASF GitHub Bot logged work on BEAM-3301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 00:58
Start Date: 19/Mar/20 00:58
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #11144: [BEAM-3301]
Perform SDF validation (missing RestrictionTrackers).
URL: https://github.com/apache/beam/pull/11144#discussion_r394618692
##########
File path: sdks/go/pkg/beam/core/graph/fn.go
##########
@@ -196,13 +217,31 @@ func (f *DoFn) Name() string {
// IsSplittable returns whether the DoFn is a valid Splittable DoFn.
func (f *DoFn) IsSplittable() bool {
- return false // TODO(BEAM-3301): Implement this when we add SDFs.
+ isSdf, _ := validateSdfMethodsPresent((*Fn)(f))
Review comment:
A semantic note: the error shouldn't be ignored. Semantically if a function
returns an error, the non error return values are not guaranteed to be valid.
So conventionally, the way to handle IsSplittable here is to check for the
error, and return false if not nil, and otherwise return what the boolean is.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 405882)
Time Spent: 5h 50m (was: 5h 40m)
> Go SplittableDoFn support
> -------------------------
>
> Key: BEAM-3301
> URL: https://issues.apache.org/jira/browse/BEAM-3301
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 5h 50m
> Remaining Estimate: 0h
>
> SDFs will be the only way to add streaming and liquid sharded IO for Go.
> Design doc: https://s.apache.org/splittable-do-fn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
