[
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=406555&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406555
]
ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 20:26
Start Date: 19/Mar/20 20:26
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11167: [BEAM-4374]
Define the protos for a "short" id mechanism for metrics
URL: https://github.com/apache/beam/pull/11167#discussion_r395299472
##########
File path: model/fn-execution/src/main/proto/beam_fn_api.proto
##########
@@ -277,6 +291,21 @@ message ProcessBundleProgressRequest {
string instruction_id = 1;
}
+// A request to provide full MonitoringInfo for a given bundle.
+//
+// An SDK can report metrics using an identifier that only contains the
+// associated payload. A runner who wants to receive the full metrics
+// information can request all the monitoring metadata via a
+// ProcessBundleProgressMetadataRequest providing a list of ids as necessary.
+//
+// The SDK is allowed to reuse the identifiers across multiple bundles as long
+// as the MonitoringInfo could be reconstructed fully by overwriting its
+// payload field with the bytes specified here.
+message ProcessBundleProgressMetadataRequest {
+ // A list of ids for which the full MonitoringInfo is requested for.
+ repeated string id = 1;
Review comment:
Done
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 406555)
Time Spent: 18h (was: 17h 50m)
> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
> Key: BEAM-4374
> URL: https://issues.apache.org/jira/browse/BEAM-4374
> Project: Beam
> Issue Type: New Feature
> Components: beam-model
> Reporter: Alex Amato
> Priority: Major
> Time Spent: 18h
> Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
> * Check in new protos
> * Define catalog file for metrics
> * Port existing metrics to use this new format, based on catalog
> names+metadata
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
