[
https://issues.apache.org/jira/browse/BEAM-9340?focusedWorklogId=406566&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406566
]
ASF GitHub Bot logged work on BEAM-9340:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 20:49
Start Date: 19/Mar/20 20:49
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11165: [BEAM-9340]
Populate requirements for Java.
URL: https://github.com/apache/beam/pull/11165#discussion_r395306659
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/PTransformTranslation.java
##########
@@ -124,6 +124,15 @@
public static final String
SPLITTABLE_PROCESS_SIZED_ELEMENTS_AND_RESTRICTIONS_URN =
"beam:transform:sdf_process_sized_element_and_restrictions:v1";
+ public static final String REQUIRES_STATEFUL_PROCESSING_URN =
+ getUrn(RunnerApi.StandardRequirements.Enum.REQUIRES_STATEFUL_PROCESSING);
Review comment:
Please define string constants and then validate that they match in the
static initializer. This allows for the string constants to be used in
switch/case statements since they are compile time constants.
I have pr/11162 which duplicates this effort, which ever goes in second
needs to get updated.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 406566)
Time Spent: 1h (was: 50m)
> Properly populate pipeline proto requirements.
> ----------------------------------------------
>
> Key: BEAM-9340
> URL: https://issues.apache.org/jira/browse/BEAM-9340
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 1h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
