[
https://issues.apache.org/jira/browse/BEAM-9524?focusedWorklogId=406579&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-406579
]
ASF GitHub Bot logged work on BEAM-9524:
----------------------------------------
Author: ASF GitHub Bot
Created on: 19/Mar/20 21:03
Start Date: 19/Mar/20 21:03
Worklog Time Spent: 10m
Work Description: davidyan74 commented on pull request #11128:
[BEAM-9524] Fix for ib.show() executing indefinitely
URL: https://github.com/apache/beam/pull/11128#discussion_r395318403
##########
File path: sdks/python/apache_beam/runners/interactive/pipeline_instrument.py
##########
@@ -63,6 +63,24 @@ def __hash__(self):
self.producer_version))
+# TODO: turn this into a dataclass object when we finally get off of Python2.
+class CacheKey:
+ def __init__(self, var, version, producer_version, pipeline_id):
+ self.var = var
+ self.version = version
+ self.producer_version = producer_version
+ self.pipeline_id = pipeline_id
+
+ @staticmethod
+ def from_str(r):
+ split = r.split('|')
Review comment:
I think probably a better way is to do the following:
```
var, version, producer_version, pipeline_id = r.split('|')
return CacheKey(var, version, producer_version, pipeline_id)
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 406579)
Time Spent: 2h 10m (was: 2h)
> ib.show() spins forever when cells are re-executed
> --------------------------------------------------
>
> Key: BEAM-9524
> URL: https://issues.apache.org/jira/browse/BEAM-9524
> Project: Beam
> Issue Type: Bug
> Components: runner-py-interactive
> Reporter: Sam Rohde
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
