[
https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=407186&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407186
]
ASF GitHub Bot logged work on BEAM-3301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 19:12
Start Date: 20/Mar/20 19:12
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #11179: [BEAM-3301]
Bugfix in DoFn validation.
URL: https://github.com/apache/beam/pull/11179#discussion_r395840270
##########
File path: sdks/go/pkg/beam/core/graph/fn.go
##########
@@ -446,23 +444,16 @@ func validateMainInputs(fn *Fn, method *funcx.Fn,
methodName string, numMainIn m
return err
}
- // Check that the first numMainIn inputs are not side inputs (Iters or
- // ReIters). We aren't able to catch singleton side inputs here since
- // they're indistinguishable from main inputs.
- mainInputs := method.Param[pos : pos+int(numMainIn)]
- for i, p := range mainInputs {
- if p.Kind != funcx.FnValue {
- err := errors.Errorf("expected main input parameter but
found "+
- "side input parameter in position %v",
- pos+i)
- err = errors.SetTopLevelMsgf(err,
- "Method %v in DoFn %v should have all main
inputs before side inputs, "+
- "but a side input (as Iter or ReIter)
appears as parameter %v when a "+
- "main input was expected.",
- methodName, fn.Name(), pos+i)
- err = errors.WithContextf(err, "method %v", methodName)
- return err
- }
+ // Check that the first input is not an Iter or ReIter (those aren't
valid
+ // as the first main input).
+ first := method.Param[pos].Kind
+ if first != funcx.FnValue {
+ err := errors.New("first main input parameter must be value
type")
Review comment:
...must be a value type..
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 407186)
Time Spent: 7h 50m (was: 7h 40m)
> Go SplittableDoFn support
> -------------------------
>
> Key: BEAM-3301
> URL: https://issues.apache.org/jira/browse/BEAM-3301
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 7h 50m
> Remaining Estimate: 0h
>
> SDFs will be the only way to add streaming and liquid sharded IO for Go.
> Design doc: https://s.apache.org/splittable-do-fn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
