[
https://issues.apache.org/jira/browse/BEAM-9537?focusedWorklogId=407236&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-407236
]
ASF GitHub Bot logged work on BEAM-9537:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Mar/20 20:58
Start Date: 20/Mar/20 20:58
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11153: [BEAM-9537]
Adding a new module for FnApiRunner
URL: https://github.com/apache/beam/pull/11153#discussion_r395884481
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -269,8 +269,8 @@ def visit_transform(self, transform_node):
pcoll.element_type, transform_node.full_label)
key_type, value_type = pcoll.element_type.tuple_types
if transform_node.outputs:
- from apache_beam.runners.portability.fn_api_runner_transforms
import \
- only_element
+ from apache_beam.runners.portability.fn_api_runner.transforms \
Review comment:
You don't have to do this in this PR, but this should probably be in
apache_beam/utils.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 407236)
Time Spent: 1.5h (was: 1h 20m)
> Refactor FnApiRunner into its own package
> -----------------------------------------
>
> Key: BEAM-9537
> URL: https://issues.apache.org/jira/browse/BEAM-9537
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Minor
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
