[
https://issues.apache.org/jira/browse/BEAM-9430?focusedWorklogId=408077&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408077
]
ASF GitHub Bot logged work on BEAM-9430:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/20 17:21
Start Date: 23/Mar/20 17:21
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #11192: [BEAM-9430]
Fix coder sent to Dataflow service for non-portable pipelines due to
WatermarkEstimators migration change
URL: https://github.com/apache/beam/pull/11192#discussion_r396622145
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowPipelineTranslator.java
##########
@@ -978,12 +978,16 @@ public void translate(ParDo.MultiOutput transform,
TranslationContext context) {
if (context.isFnApi()) {
DoFnSignature signature =
DoFnSignatures.signatureForDoFn(transform.getFn());
if (signature.processElement().isSplittable()) {
- Coder<?> restrictionCoder =
- DoFnInvokers.invokerFor(transform.getFn())
- .invokeGetRestrictionCoder(
-
context.getInput(transform).getPipeline().getCoderRegistry());
+ DoFnInvoker<?, ?> doFnInvoker =
DoFnInvokers.invokerFor(transform.getFn());
+ Coder<?> restrictionAndWatermarkStateCoder =
+ KvCoder.of(
+ doFnInvoker.invokeGetRestrictionCoder(
+
context.getInput(transform).getPipeline().getCoderRegistry()),
+ doFnInvoker.invokeGetWatermarkEstimatorStateCoder(
Review comment:
Just curious what if someone has SDF without provide WatermarkEstimator?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 408077)
Time Spent: 4.5h (was: 4h 20m)
> Migrate from ProcessContext#updateWatermark to WatermarkEstimators
> ------------------------------------------------------------------
>
> Key: BEAM-9430
> URL: https://issues.apache.org/jira/browse/BEAM-9430
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Luke Cwik
> Priority: Major
> Labels: backward-incompatible
> Fix For: 2.21.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> Current discussion underway in
> [https://lists.apache.org/thread.html/r5d974b6a58bc04ff4c02682fda4ef68608121f1bf23a86e9d592ca6e%40%3Cdev.beam.apache.org%3E]
>
> Proposed API: [https://github.com/apache/beam/pull/10992]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
