[
https://issues.apache.org/jira/browse/BEAM-7746?focusedWorklogId=408163&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-408163
]
ASF GitHub Bot logged work on BEAM-7746:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Mar/20 19:12
Start Date: 23/Mar/20 19:12
Worklog Time Spent: 10m
Work Description: chadrik commented on pull request #11038: [BEAM-7746]
More typing fixes
URL: https://github.com/apache/beam/pull/11038#discussion_r396693751
##########
File path: sdks/python/mypy.ini
##########
@@ -17,16 +17,21 @@
[mypy]
python_version = 3.6
+files = apache_beam
ignore_missing_imports = true
-follow_imports = true
-warn_no_return = true
no_implicit_optional = true
+# warnings:
+warn_no_return = true
warn_redundant_casts = true
warn_unused_ignores = true
+# formatting:
show_error_codes = true
-files = apache_beam
color_output = true
-# uncomment this to see how close we are to being complete
+# required setting for dmypy:
+follow_imports = error
Review comment:
mypy picks up the site-packages directory of the python that it's installed
into. Only PEP 561 compliant packages will inform the type analysis (i.e. the
package must have a `py.typed` file). Alternately, you can specify the
interpreter for finding site-packages with `--python-executable`:
```
--python-executable EXECUTABLE
Python executable used for finding PEP 561
compliant installed packages and stubs
```
This config change did not generate any additional errors for me.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 408163)
Time Spent: 77h 40m (was: 77.5h)
> Add type hints to python code
> -----------------------------
>
> Key: BEAM-7746
> URL: https://issues.apache.org/jira/browse/BEAM-7746
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chad Dombrova
> Assignee: Chad Dombrova
> Priority: Major
> Time Spent: 77h 40m
> Remaining Estimate: 0h
>
> As a developer of the beam source code, I would like the code to use pep484
> type hints so that I can clearly see what types are required, get completion
> in my IDE, and enforce code correctness via a static analyzer like mypy.
> This may be considered a precursor to BEAM-7060
> Work has been started here: [https://github.com/apache/beam/pull/9056]
>
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
