[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=409241&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409241
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Mar/20 00:37
Start Date: 25/Mar/20 00:37
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Some generalizations to support cross-language transforms.
URL: https://github.com/apache/beam/pull/11185#discussion_r397543233
##########
File path: sdks/python/apache_beam/pvalue.py
##########
@@ -208,9 +233,23 @@ def from_runner_api(proto, context):
# deserialization. It will be populated soon after this call, in
# Pipeline.from_runner_api(). This brief period is the only time that
# PCollection.pipeline is allowed to be None.
+
+ try:
+ element_type = context.element_type_from_coder_id(proto.coder_id)
Review comment:
Have this method do the ExternalCoder stuff rather than catching an
exception here. Possibly it would not even be needed if the coders map is
properly populated beforehand.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 409241)
Time Spent: 10h (was: 9h 50m)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 10h
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
