[ 
https://issues.apache.org/jira/browse/BEAM-4374?focusedWorklogId=409976&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409976
 ]

ASF GitHub Bot logged work on BEAM-4374:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 25/Mar/20 23:53
            Start Date: 25/Mar/20 23:53
    Worklog Time Spent: 10m 
      Work Description: lostluck commented on pull request #11184: 
[WIP][BEAM-4374] Update protos related to MonitoringInfo.
URL: https://github.com/apache/beam/pull/11184#discussion_r398238942
 
 

 ##########
 File path: sdks/go/pkg/beam/core/runtime/harness/monitoring.go
 ##########
 @@ -126,15 +134,18 @@ func monitoring(p *exec.Plan) (*fnpb.Metrics, 
[]*ppb.MonitoringInfo) {
                        },
                }
                // Monitoring info version.
-               monitoringInfo = append(monitoringInfo,
-                       &ppb.MonitoringInfo{
-                               Urn:  "beam:metric:element_count:v1",
-                               Type: "beam:metrics:sum_int_64",
-                               Labels: map[string]string{
-                                       "PCOLLECTION": snapshot.PID,
-                               },
-                               Data: int64Counter(snapshot.Count),
-                       })
+               payload, err := int64Counter(snapshot.Count)
+               if err != nil {
 
 Review comment:
   Error case reversal. 
   Consider 
   ```
   if err != nil {
     panic(err)
   }
   // ...actual contents of the block. 
   ```
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Issue Time Tracking
-------------------

    Worklog Id:     (was: 409976)
    Time Spent: 22h 40m  (was: 22.5h)

> Update existing metrics in the FN API to use new Metric Schema
> --------------------------------------------------------------
>
>                 Key: BEAM-4374
>                 URL: https://issues.apache.org/jira/browse/BEAM-4374
>             Project: Beam
>          Issue Type: New Feature
>          Components: beam-model
>            Reporter: Alex Amato
>            Priority: Major
>          Time Spent: 22h 40m
>  Remaining Estimate: 0h
>
> Update existing metrics to use the new proto and cataloging schema defined in:
> [_https://s.apache.org/beam-fn-api-metrics_]
>  * Check in new protos
>  * Define catalog file for metrics
>  * Port existing metrics to use this new format, based on catalog 
> names+metadata



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to