[
https://issues.apache.org/jira/browse/BEAM-9214?focusedWorklogId=409989&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-409989
]
ASF GitHub Bot logged work on BEAM-9214:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/20 00:29
Start Date: 26/Mar/20 00:29
Worklog Time Spent: 10m
Work Description: ibzib commented on issue #11213: [BEAM-9214] Add
missing argument to GetJobMetrics.
URL: https://github.com/apache/beam/pull/11213#issuecomment-604159640
> Could you elaborate on why this change is needed?
@kamilwu Check out the
[jira](https://issues.apache.org/jira/browse/BEAM-9214). The current code
assumes the `context` argument is optional, but the generated code in the
default implementation requires it, meaning instead of getting the correct
error (`NotImplementedError`) I was getting a confusing `TypeError`. I will fix
that underlying issue in a different PR, however we should change this code so
that it provides the proper error message to the next person who runs into it.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 409989)
Time Spent: 0.5h (was: 20m)
> TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
> ----------------------------------------------------------------------------
>
> Key: BEAM-9214
> URL: https://issues.apache.org/jira/browse/BEAM-9214
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Labels: portability-flink
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've seen this error myself, and had multiple users report it, but I don't
> know what causes it. In this case, it happened when using
> --flink_submit_uber_jar. But the job succeeded when retried. (EDIT: User
> reported job worked when retried; I have no idea why that might happen.)
> INFO:root:Started Flink job as 2d1bf5003307c580900abe6bbe56d9e8
> INFO:root:Job state changed to STOPPED
> INFO:root:Job state changed to RUNNING
> Traceback (most recent call last):
> File "/usr/local/lib/python3.7/runpy.py", line 193, in _run_module_as_main
> "__main__", mod_spec)
> File "/usr/local/lib/python3.7/runpy.py", line 85, in _run_code
> exec(code, run_globals)
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py",
> line 138, in <module>
> run()
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/examples/wordcount.py",
> line 124, in run
> query_result = result.metrics().query(empty_lines_filter)
> File
> "/usr/local/lib/python3.7/site-packages/apache_beam/runners/portability/portable_runner.py",
> line 390, in metrics
> beam_job_api_pb2.GetJobMetricsRequest(job_id=self._job_id))
> TypeError: GetJobMetrics() missing 1 required positional argument: 'context'
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
