[
https://issues.apache.org/jira/browse/BEAM-9340?focusedWorklogId=410372&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410372
]
ASF GitHub Bot logged work on BEAM-9340:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/20 16:10
Start Date: 26/Mar/20 16:10
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11224: [BEAM-9340]
Validate pipeline requirements in PipelineValidator.
URL: https://github.com/apache/beam/pull/11224#discussion_r398695607
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/graph/PipelineValidator.java
##########
@@ -221,23 +229,39 @@ private static void validateParDo(String id, PTransform
transform, Components co
id,
sideInputId);
}
- // TODO: Validate state_specs and timer_specs
+ if (payload.getStateSpecsCount() > 0 || payload.getTimerSpecsCount() > 0) {
Review comment:
This should also have timer family specs.
@boyuanzz Once this code is merged, this is another place where TimerSpecs
will need to be removed.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 410372)
Time Spent: 4h 20m (was: 4h 10m)
> Properly populate pipeline proto requirements.
> ----------------------------------------------
>
> Key: BEAM-9340
> URL: https://issues.apache.org/jira/browse/BEAM-9340
> Project: Beam
> Issue Type: New Feature
> Components: beam-model, sdk-go, sdk-java-core, sdk-py-core
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Fix For: 2.20.0
>
> Time Spent: 4h 20m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
