[
https://issues.apache.org/jira/browse/BEAM-8603?focusedWorklogId=410544&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-410544
]
ASF GitHub Bot logged work on BEAM-8603:
----------------------------------------
Author: ASF GitHub Bot
Created on: 26/Mar/20 19:42
Start Date: 26/Mar/20 19:42
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #10055: [BEAM-8603]
Add Python SqlTransform
URL: https://github.com/apache/beam/pull/10055#discussion_r398843618
##########
File path:
sdks/java/extensions/sql/src/main/java/org/apache/beam/sdk/extensions/sql/SqlTransform.java
##########
@@ -271,6 +275,19 @@ static Builder builder() {
abstract Builder setDefaultTableProvider(@Nullable String
defaultTableProvider);
abstract SqlTransform build();
+
+ @Override
+ public PTransform<PInput, PCollection<Row>> buildExternal(
+ External.Configuration configuration) {
+ return builder()
Review comment:
@chamikaramj @chadrik It'd be nice to reduce this boilerplate to almost
nothing, given we're already using the builder pattern here, or a minimal
mapping of names (e.g. query -> queryString).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 410544)
Time Spent: 4.5h (was: 4h 20m)
> Add Python SqlTransform example script
> --------------------------------------
>
> Key: BEAM-8603
> URL: https://issues.apache.org/jira/browse/BEAM-8603
> Project: Beam
> Issue Type: Improvement
> Components: sdk-py-core
> Reporter: Brian Hulette
> Assignee: Brian Hulette
> Priority: Major
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
