[
https://issues.apache.org/jira/browse/BEAM-9608?focusedWorklogId=411444&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411444
]
ASF GitHub Bot logged work on BEAM-9608:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 22:42
Start Date: 27/Mar/20 22:42
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #11229: [BEAM-9608]
Increasing scope of context managers for FnApiRunner
URL: https://github.com/apache/beam/pull/11229#discussion_r399570204
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/execution.py
##########
@@ -245,37 +254,106 @@ class FnApiRunnerExecutionContext(object):
``beam.PCollection``.
"""
def __init__(self,
- worker_handler_factory, # type: Callable[[Optional[str], int],
List[WorkerHandler]]
+ worker_handler_manager, # type: worker_handlers.WorkerHandlerManager
pipeline_components, # type: beam_runner_api_pb2.Components
safe_coders,
data_channel_coders,
):
"""
- :param worker_handler_factory: A ``callable`` that takes in an environment
+ :param worker_handler_manager: A ``callable`` that takes in an environment
Review comment:
Done.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411444)
Time Spent: 1.5h (was: 1h 20m)
> Add context managers for FnApiRunner to manage execution of each bundle
> -----------------------------------------------------------------------
>
> Key: BEAM-9608
> URL: https://issues.apache.org/jira/browse/BEAM-9608
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-py-core
> Reporter: Pablo Estrada
> Assignee: Pablo Estrada
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
