[
https://issues.apache.org/jira/browse/BEAM-8019?focusedWorklogId=411461&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411461
]
ASF GitHub Bot logged work on BEAM-8019:
----------------------------------------
Author: ASF GitHub Bot
Created on: 27/Mar/20 23:07
Start Date: 27/Mar/20 23:07
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11185: [BEAM-8019]
Updates Python SDK to handle remote SDK coders and preserve tags added by
remote SDKs
URL: https://github.com/apache/beam/pull/11185#discussion_r399564536
##########
File path: sdks/python/apache_beam/pipeline.py
##########
@@ -1128,29 +1136,67 @@ def from_runner_api(proto, # type:
beam_runner_api_pb2.PTransform
context # type: PipelineContext
):
# type: (...) -> AppliedPTransform
- def is_side_input(tag):
+ def is_python_side_input(tag):
# type: (str) -> bool
# As per named_inputs() above.
- return tag.startswith('side')
+ return re.match(SIDE_INPUT_REGEX, tag)
Review comment:
This'll break if a java user names their side inputs coincidentally
something that matches.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 411461)
> Support cross-language transforms for DataflowRunner
> ----------------------------------------------------
>
> Key: BEAM-8019
> URL: https://issues.apache.org/jira/browse/BEAM-8019
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-core
> Reporter: Chamikara Madhusanka Jayalath
> Assignee: Chamikara Madhusanka Jayalath
> Priority: Major
> Time Spent: 11h 20m
> Remaining Estimate: 0h
>
> This is to capture the Beam changes needed for this task.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
