[
https://issues.apache.org/jira/browse/BEAM-9571?focusedWorklogId=411900&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-411900
]
ASF GitHub Bot logged work on BEAM-9571:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/20 09:41
Start Date: 29/Mar/20 09:41
Worklog Time Spent: 10m
Work Description: iemejia commented on pull request #11258: [BEAM-9571]
Add withMongoClientProvider to MongoDbIO
URL: https://github.com/apache/beam/pull/11258#discussion_r399772016
##########
File path:
sdks/java/io/mongodb/src/main/java/org/apache/beam/sdk/io/mongodb/MongoDbIO.java
##########
@@ -166,7 +165,7 @@ private MongoDbIO() {}
abstract SerializableFunction<MongoCollection<Document>,
MongoCursor<Document>> queryFn();
- abstract Builder builder();
+ abstract Builder toBuilder();
Review comment:
This rename is slightly unreated to this PR but an improvement to be
consistent with [AutoValue
conventions](https://github.com/google/auto/blob/master/value/userguide/builders-howto.md#to_builder).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 411900)
Time Spent: 20m (was: 10m)
> Add withMongoClientProvider to MongoDbIO
> ----------------------------------------
>
> Key: BEAM-9571
> URL: https://issues.apache.org/jira/browse/BEAM-9571
> Project: Beam
> Issue Type: Improvement
> Components: io-java-mongodb
> Reporter: Ismaël Mejía
> Assignee: Ismaël Mejía
> Priority: Minor
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Users of MongoDB may want to provide more details or configure advanced
> parameteres like SSL validations explicitly. We can offer a method
> `.withMongoClientProvider` that provides clients as needed as we do in other
> IOs.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
