[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=412296&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412296
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/20 12:31
Start Date: 30/Mar/20 12:31
Worklog Time Spent: 10m
Work Description: tvalentyn commented on pull request #11067:
[BEAM-9136]Add licenses for dependencies for Python
URL: https://github.com/apache/beam/pull/11067#discussion_r399712846
##########
File path: sdks/python/container/license_scripts/dep_urls_py.yaml
##########
@@ -0,0 +1,116 @@
+#
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+#
+pip_dependencies:
+ # this is a list of packages whose license cannot be pulled with
pip-licenses tool.
Review comment:
Consider following wording:
```
# This is a list of packages whose license files cannot be pulled with
pip-licenses tool.
# pip-licenses scans site-packages/ directory to get a list of packages
installed and their licenses.
# For packages that do not include licenses in their distribution, we need
to manually
# provide license files in ./manual_licences/, or provide a url where they
can be downloaded from.
# We need to manually configure licenses for a dependency if pip-licenses
fails to retrieve
# the license file under any Python version we support.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 412296)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 11.5h
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
