[
https://issues.apache.org/jira/browse/BEAM-3301?focusedWorklogId=412609&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-412609
]
ASF GitHub Bot logged work on BEAM-3301:
----------------------------------------
Author: ASF GitHub Bot
Created on: 30/Mar/20 21:40
Start Date: 30/Mar/20 21:40
Worklog Time Spent: 10m
Work Description: youngoli commented on pull request #11257: [BEAM-3301]
Create runtime invokers for SDF methods.
URL: https://github.com/apache/beam/pull/11257#discussion_r400511146
##########
File path: sdks/go/pkg/beam/core/runtime/exec/sdf_invokers.go
##########
@@ -0,0 +1,131 @@
+// Licensed to the Apache Software Foundation (ASF) under one or more
+// contributor license agreements. See the NOTICE file distributed with
+// this work for additional information regarding copyright ownership.
+// The ASF licenses this file to You under the Apache License, Version 2.0
+// (the "License"); you may not use this file except in compliance with
+// the License. You may obtain a copy of the License at
+//
+// http://www.apache.org/licenses/LICENSE-2.0
+//
+// Unless required by applicable law or agreed to in writing, software
+// distributed under the License is distributed on an "AS IS" BASIS,
+// WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+// See the License for the specific language governing permissions and
+// limitations under the License.
+
+package exec
+
+import (
+ "github.com/apache/beam/sdks/go/pkg/beam/core/funcx"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/sdf"
+ "github.com/apache/beam/sdks/go/pkg/beam/core/util/reflectx"
+ "github.com/apache/beam/sdks/go/pkg/beam/internal/errors"
+ "reflect"
+)
+
+func invokeCreateInitialRestriction(fn *funcx.Fn, elms *FullValue) (rest
interface{}, err error) {
+ if fn == nil {
+ return nil, nil
+ }
+
+ switch fnT := fn.Fn.(type) {
+ case reflectx.Func1x1:
+ return fnT.Call1x1(elms.Elm), nil
+ case reflectx.Func2x1:
+ return fnT.Call2x1(elms.Elm, elms.Elm2), nil
+ default:
+ var inputs []interface{}
+ switch fn.Fn.Type().NumIn() {
+ case 1:
+ inputs = []interface{}{elms.Elm}
+ case 2:
+ inputs = []interface{}{elms.Elm, elms.Elm2}
+ default:
+ err := errors.Errorf("fn %v has unexpected number of
inputs: %v", fn.Fn.Name(), fn.Fn.Type().NumIn())
+ return nil, errors.WithContext(err, "sdf
CreateInitialRestriction invoker")
+ }
+ rets := fn.Fn.Call(inputs)
+ return rets[0], nil
+ }
+}
+
+func invokeSplitRestriction(fn *funcx.Fn, elms *FullValue, rest interface{})
([]interface{}, error) {
Review comment:
Yeah, I was going to document the abstract signatures in the frontend
comment for SDF, which will most likely be in the same comment that currently
documents DoFns (I think it's in beam/pardo.go).
That said, I can definitely leave a comment here, with a TODO to replace it
when the frontend documentation is in.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 412609)
Time Spent: 12h (was: 11h 50m)
> Go SplittableDoFn support
> -------------------------
>
> Key: BEAM-3301
> URL: https://issues.apache.org/jira/browse/BEAM-3301
> Project: Beam
> Issue Type: Improvement
> Components: sdk-go
> Reporter: Henning Rohde
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 12h
> Remaining Estimate: 0h
>
> SDFs will be the only way to add streaming and liquid sharded IO for Go.
> Design doc: https://s.apache.org/splittable-do-fn
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
