[
https://issues.apache.org/jira/browse/BEAM-9638?focusedWorklogId=413328&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413328
]
ASF GitHub Bot logged work on BEAM-9638:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Mar/20 16:27
Start Date: 31/Mar/20 16:27
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #11267: [BEAM-9638]
Strengthen worker region & zone options tests.
URL: https://github.com/apache/beam/pull/11267
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 413328)
Time Spent: 20m (was: 10m)
> False positives in worker region & zone tests
> ---------------------------------------------
>
> Key: BEAM-9638
> URL: https://issues.apache.org/jira/browse/BEAM-9638
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> This is hypothetical (I haven't seen this actually happen), but worker region
> & zone tests in the Python SDK could yield false positives because they only
> check that errors occurred. They do not check _which_ errors occurred. The
> pipeline options under test raise other expected errors: ['Missing required
> option: project.', 'Missing GCS path option: temp_location.', 'Missing GCS
> path option: staging_location.'] in addition to the error we're actually
> testing for. Therefore, if the code under test were to break, the tests would
> still pass.
> https://github.com/apache/beam/blob/e2ff3967609df50ec55d18cc58fe8359ef4cacb8/sdks/python/apache_beam/options/pipeline_options_validator_test.py#L379
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
