[
https://issues.apache.org/jira/browse/BEAM-8889?focusedWorklogId=413636&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-413636
]
ASF GitHub Bot logged work on BEAM-8889:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 00:33
Start Date: 01/Apr/20 00:33
Worklog Time Spent: 10m
Work Description: vnorigoog commented on issue #11183: [BEAM-8889]add
experiment flag use_grpc_for_gcs
URL: https://github.com/apache/beam/pull/11183#issuecomment-606959315
That is a real problem.
unused variable "gcsOptions"
Thanks, Luke.
could you please issue "Run Java PreCommit" again.
I am trying to understand
1. why local build didn't show this error when spotbugs ran on it.
2. why didn't I see this error on github you saw. I should have. I wonder
if I didn't look in the right place. not happy with myself
On Tue, Mar 31, 2020 at 4:50 PM Lukasz Cwik <[email protected]>
wrote:
> It looks like spotbugs is failing in the Java PreCommit with:
>
> Dead store to gcsOptions in
org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions,
Storage, HttpRequestInitializer, ExecutorService, Integer)
> Bug type DLS_DEAD_LOCAL_STORE (click for details)
> In class org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory
> In method
org.apache.beam.sdk.extensions.gcp.util.GcsUtil$GcsUtilFactory.create(PipelineOptions,
Storage, HttpRequestInitializer, ExecutorService, Integer)
> Local variable named gcsOptions
> At GcsUtil.java:[line 115]
>
> —
> You are receiving this because you authored the thread.
> Reply to this email directly, view it on GitHub
> <https://github.com/apache/beam/pull/11183#issuecomment-606946300>, or
> unsubscribe
>
<https://github.com/notifications/unsubscribe-auth/ALRAMQU6NKEJDI3ZY46PCHTRKJ6T3ANCNFSM4LQRRJQQ>
> .
>
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 413636)
Remaining Estimate: 146h 40m (was: 146h 50m)
Time Spent: 21h 20m (was: 21h 10m)
> Make GcsUtil use GoogleCloudStorage
> -----------------------------------
>
> Key: BEAM-8889
> URL: https://issues.apache.org/jira/browse/BEAM-8889
> Project: Beam
> Issue Type: Improvement
> Components: io-java-gcp
> Affects Versions: 2.16.0
> Reporter: Esun Kim
> Assignee: VASU NORI
> Priority: Major
> Labels: gcs
> Original Estimate: 168h
> Time Spent: 21h 20m
> Remaining Estimate: 146h 40m
>
> [GcsUtil|https://github.com/apache/beam/blob/master/sdks/java/extensions/google-cloud-platform-core/src/main/java/org/apache/beam/sdk/extensions/gcp/util/GcsUtil.java]
> is a primary class to access Google Cloud Storage on Apache Beam. Current
> implementation directly creates GoogleCloudStorageReadChannel and
> GoogleCloudStorageWriteChannel by itself to read and write GCS data rather
> than using
> [GoogleCloudStorage|https://github.com/GoogleCloudPlatform/bigdata-interop/blob/master/gcsio/src/main/java/com/google/cloud/hadoop/gcsio/GoogleCloudStorage.java]
> which is an abstract class providing basic IO capability which eventually
> creates channel objects. This request is about updating GcsUtil to use
> GoogleCloudStorage to create read and write channel, which is expected
> flexible because it can easily pick up the new change; e.g. new channel
> implementation using new protocol without code change.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
