[
https://issues.apache.org/jira/browse/BEAM-9636?focusedWorklogId=414299&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414299
]
ASF GitHub Bot logged work on BEAM-9636:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 21:33
Start Date: 01/Apr/20 21:33
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11266: [BEAM-9636]
Using TimerFamily should also be considered as stateful.
URL: https://github.com/apache/beam/pull/11266#discussion_r401922952
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/SplittableParDo.java
##########
@@ -416,8 +417,13 @@ public FunctionSpec translateDoFn(SdkComponents
newComponents) {
@Override
public boolean isStateful() {
- return !signature.stateDeclarations().isEmpty()
- || !signature.timerDeclarations().isEmpty();
+ // SDFs should not have user timer/state.
+ checkState(
+ signature.stateDeclarations().isEmpty()
+ && signature.timerDeclarations().isEmpty()
+ && signature.timerFamilyDeclarations().isEmpty(),
+ "SDFs should not have user state/timer.");
Review comment:
This does not seem the right place to prohibit this--we should just pass
through what is present. (It is true that some runners may not support it
(yet?).)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414299)
Time Spent: 2.5h (was: 2h 20m)
> Run Dataflow ValidatesRunner
> (:runners:google-cloud-dataflow-java:validatesRunnerLegacyWorkerTest) failing
> ----------------------------------------------------------------------------------------------------------
>
> Key: BEAM-9636
> URL: https://issues.apache.org/jira/browse/BEAM-9636
> Project: Beam
> Issue Type: Task
> Components: runner-dataflow
> Reporter: Tomo Suzuki
> Priority: Major
> Time Spent: 2.5h
> Remaining Estimate: 0h
>
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/4719/console
> {noformat}
> 00:27:33 > Task
> :runners:google-cloud-dataflow-java:validatesRunnerLegacyWorkerTest
> 00:28:48
> 00:28:48 org.apache.beam.sdk.transforms.ParDoTest$TimerFamilyTests >
> testTimerWithMultipleTimerFamilyUnbounded FAILED
> 00:28:48 java.lang.RuntimeException at ParDoTest.java:4770
> 00:28:48 Caused by: java.lang.IllegalArgumentException at
> ParDoTest.java:4770
> 00:42:57
> 00:42:57 org.apache.beam.sdk.transforms.ParDoTest$TimerFamilyTests >
> testTimerFamilyEventTimeUnbounded FAILED
> 00:42:57 java.lang.RuntimeException at ParDoTest.java:4708
> 00:42:57 Caused by: java.lang.IllegalArgumentException at
> ParDoTest.java:4708
> {noformat}
> History:
> https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
