[
https://issues.apache.org/jira/browse/BEAM-9578?focusedWorklogId=414307&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414307
]
ASF GitHub Bot logged work on BEAM-9578:
----------------------------------------
Author: ASF GitHub Bot
Created on: 01/Apr/20 21:49
Start Date: 01/Apr/20 21:49
Worklog Time Spent: 10m
Work Description: ihji commented on pull request #11205: [BEAM-9578]
Enumerating artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r401930784
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1146,33 +1146,41 @@ message StandardArtifacts {
enum Types {
// A URN for locally-accessible artifact files.
// payload: ArtifactFilePayload
- FILE = 0 [(beam_urn) = "beam:artifact:type:file:v1"];
+ FILE = 0 [(beam_urn) = "beam:artifact:type:file:v1"];
// A URN for artifacts described by URLs.
// payload: ArtifactUrlPayload
- URL = 1 [(beam_urn) = "beam:artifact:type:url:v1"];
+ URL = 1 [(beam_urn) = "beam:artifact:type:url:v1"];
// A URN for artifacts embedded in ArtifactInformation proto.
// payload: EmbeddedFilePayload.
- EMBEDDED = 2 [(beam_urn) = "beam:artifact:type:embedded:v1"];
+ EMBEDDED = 2 [(beam_urn) = "beam:artifact:type:embedded:v1"];
// A URN for Python artifacts hosted on PYPI.
// payload: PypiPayload
- PYPI = 3 [(beam_urn) = "beam:artifact:type:pypi:v1"];
+ PYPI = 3 [(beam_urn) = "beam:artifact:type:pypi:v1"];
// A URN for Java artifacts hosted on a Maven repository.
// payload: MavenPayload
- MAVEN = 4 [(beam_urn) = "beam:artifact:type:maven:v1"];
+ MAVEN = 4 [(beam_urn) = "beam:artifact:type:maven:v1"];
+
+ // A URN for locally-accessible artifact directory.
+ // payload: ArtifactDirectoryPayload
+ DIRECTORY = 5 [(beam_urn) = "beam:artifact:type:directory:v1"];
}
enum Roles {
// A URN for staging-to role.
// payload: ArtifactStagingToRolePayload
STAGING_TO = 0 [(beam_urn) = "beam:artifact:role:staging_to:v1"];
+
+ // A URN for unzip-to role.
+ // payload: ArtifactUnzipToRolePayload
+ UNZIP_TO = 1 [(beam_urn) = "beam:artifact:role:unzip_to:v1"];
}
}
message ArtifactFilePayload {
- // a string for an artifact path e.g. "/tmp/foo.jar"
+ // a string for an artifact file path e.g. "/tmp/foo.jar"
string path = 1;
// The hex-encoded sha256 checksum of the artifact.
Review comment:
adding deferred artifacts and populating sha256.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
Issue Time Tracking
-------------------
Worklog Id: (was: 414307)
Time Spent: 1h 40m (was: 1.5h)
> Enumerating artifacts is too expensive in Java
> ----------------------------------------------
>
> Key: BEAM-9578
> URL: https://issues.apache.org/jira/browse/BEAM-9578
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Heejong Lee
> Priority: Critical
> Labels: portability
> Fix For: 2.21.0
>
> Time Spent: 1h 40m
> Remaining Estimate: 0h
>
> There are a lot of places (e.g. *ParDoTranslation#getParDoPayload*) which
> effectively call *Environments#createOrGetDefaultEnvironment* which causes
> [artifacts to be
> computed|https://github.com/apache/beam/blob/fc6cef9972780ca6b7525d4aadd65a8344221f1b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java#L114].
> This leads to zipping directories for non-jar dependencies.
> Similar problems may exist for Python/Go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
