[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=414805&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-414805
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 16:17
Start Date: 02/Apr/20 16:17
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199: [BEAM-9562]
Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402414733
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Timer.java
##########
@@ -40,92 +50,197 @@
@AutoValue
public abstract class Timer<T> {
- /** Returns a timer for the given timestamp with a {@code null} payload. */
- public static Timer<Void> of(Instant time) {
- return of(time, (Void) null);
+ /**
+ * Returns a non-cleared timer for the given userKey, dynamicTimerTag,
fireTimestamp,
+ * holdTimestamp, windows and pane.
Review comment:
```suggestion
* Returns a non-cleared timer for the given {@code userKey}, {@code
dynamicTimerTag}, {@code fireTimestamp},
* {@code holdTimestamp}, {@code windows} and {@code pane}.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 414805)
Time Spent: 8h 50m (was: 8h 40m)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 8h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
