[
https://issues.apache.org/jira/browse/BEAM-9147?focusedWorklogId=415053&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415053
]
ASF GitHub Bot logged work on BEAM-9147:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Apr/20 21:28
Start Date: 02/Apr/20 21:28
Worklog Time Spent: 10m
Work Description: Ardagan commented on pull request #11261: [BEAM-9147]
Add a VideoIntelligence transform to Java SDK
URL: https://github.com/apache/beam/pull/11261#discussion_r402605081
##########
File path:
sdks/java/extensions/ml/src/test/java/org/apache/beam/sdk/extensions/ml/VideoIntelligenceIT.java
##########
@@ -0,0 +1,79 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.extensions.ml;
+
+import static
org.apache.beam.sdk.extensions.ml.VideoIntelligence.annotateFromURI;
+import static org.junit.Assert.assertEquals;
+
+import com.google.cloud.videointelligence.v1.Feature;
+import com.google.cloud.videointelligence.v1.VideoAnnotationResults;
+import java.util.ArrayList;
+import java.util.Collections;
+import java.util.List;
+import org.apache.beam.sdk.testing.PAssert;
+import org.apache.beam.sdk.testing.TestPipeline;
+import org.apache.beam.sdk.transforms.Create;
+import org.apache.beam.sdk.transforms.ParDo;
+import org.apache.beam.sdk.transforms.SerializableFunction;
+import org.apache.beam.sdk.values.PCollection;
+import org.junit.Rule;
+import org.junit.Test;
+import org.junit.runner.RunWith;
+import org.junit.runners.JUnit4;
+
+@RunWith(JUnit4.class)
+public class VideoIntelligenceIT {
+ @Rule public TestPipeline testPipeline = TestPipeline.create();
+ private static final String VIDEO_URI =
+ "gs://apache-beam-samples/advanced_analytics/video/gbikes_dinosaur.mp4";
+ private List<Feature> featureList =
Collections.singletonList(Feature.LABEL_DETECTION);
+
+ @Test
+ public void annotateVideoFromURINoContext() {
+ PCollection<List<VideoAnnotationResults>> annotationResults =
+ testPipeline
+ .apply(Create.of(VIDEO_URI))
+ .apply("Annotate video", ParDo.of(annotateFromURI(featureList,
null)));
+ PAssert.that(annotationResults).satisfies(new
VerifyVideoAnnotationResult());
+ testPipeline.run().waitUntilFinish();
+ }
+
+ private static class VerifyVideoAnnotationResult
+ implements SerializableFunction<Iterable<List<VideoAnnotationResults>>,
Void> {
+
+ @Override
+ public Void apply(Iterable<List<VideoAnnotationResults>> input) {
+ List<Boolean> labelEvaluations = new ArrayList<>();
+ input.forEach(
Review comment:
This part is really hard to read. Would be good to add named methods or use
similar approach.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415053)
Time Spent: 1h (was: 50m)
> [Java] PTransform that integrates Video Intelligence functionality
> ------------------------------------------------------------------
>
> Key: BEAM-9147
> URL: https://issues.apache.org/jira/browse/BEAM-9147
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp
> Reporter: Kamil Wasilewski
> Assignee: Michał Walenia
> Priority: Major
> Time Spent: 1h
> Remaining Estimate: 0h
>
> The goal is to create a PTransform that integrates Google Cloud Video
> Intelligence functionality [1].
> The transform should be able to take both video GCS location or video data
> bytes as an input.
> A module with the transform should be put into _`sdks/java/extensions`_
> folder.
> [1] [https://cloud.google.com/video-intelligence/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
