[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=415273&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415273
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 01:55
Start Date: 03/Apr/20 01:55
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11199: [BEAM-9562]
Update Timer encoding with respect of dynamic timers
URL: https://github.com/apache/beam/pull/11199#discussion_r402692551
##########
File path:
runners/core-construction-java/src/test/java/org/apache/beam/runners/core/construction/TimerTest.java
##########
@@ -33,42 +35,128 @@
/** Tests for {@link Timer}. */
@RunWith(JUnit4.class)
public class TimerTest {
- private static final Instant INSTANT = Instant.now();
+ private static final Instant FIREINSTANT = new Instant(123L);
+ private static final Instant HOLDINSTANT = new Instant(456L);
Review comment:
```suggestion
private static final Instant FIRE_TIME = new Instant(123L);
private static final Instant HOLD_TIME = new Instant(456L);
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415273)
Time Spent: 12h 40m (was: 12.5h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Time Spent: 12h 40m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
