[
https://issues.apache.org/jira/browse/BEAM-1819?focusedWorklogId=415278&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415278
]
ASF GitHub Bot logged work on BEAM-1819:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 02:12
Start Date: 03/Apr/20 02:12
Worklog Time Spent: 10m
Work Description: shehzaadn-vd commented on pull request #11154:
[BEAM-1819] Key should be available in @OnTimer methods
URL: https://github.com/apache/beam/pull/11154#discussion_r402698024
##########
File path:
examples/java/src/main/java/org/apache/beam/examples/complete/AutoComplete.java
##########
@@ -386,7 +385,8 @@ public FormatForDatastore(String kind, String ancestorKey)
{
@ProcessElement
public void processElement(ProcessContext c) {
Entity.Builder entityBuilder = Entity.newBuilder();
- Key key = makeKey(makeKey(kind, ancestorKey).build(), kind,
c.element().getKey()).build();
+ com.google.datastore.v1.Key key =
+ makeKey(makeKey(kind, ancestorKey).build(), kind,
c.element().getKey()).build();
Review comment:
the changes in this file don't seem necessary. We've got rid of an import
but introduced a fully qualified class name for the same import instead.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415278)
Time Spent: 14h 20m (was: 14h 10m)
> Key should be available in @OnTimer methods
> -------------------------------------------
>
> Key: BEAM-1819
> URL: https://issues.apache.org/jira/browse/BEAM-1819
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Thomas Groh
> Assignee: Shehzaad Nakhoda
> Priority: Major
> Time Spent: 14h 20m
> Remaining Estimate: 0h
>
> Every timer firing has an associated key. This key should be available when
> the timer is delivered to a user's {{DoFn}}, so they don't have to store it
> in state.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
