[
https://issues.apache.org/jira/browse/BEAM-9578?focusedWorklogId=415280&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415280
]
ASF GitHub Bot logged work on BEAM-9578:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Apr/20 02:15
Start Date: 03/Apr/20 02:15
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11205: [BEAM-9578]
Enumerating artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r402698752
##########
File path: model/pipeline/src/main/proto/beam_runner_api.proto
##########
@@ -1206,6 +1210,11 @@ message MavenPayload {
string repository_url = 2;
}
+message DeferredArtifactPayload {
+ // A id for deferred artifacts.
+ string id = 1;
Review comment:
Thats a good point about the key and in general this will become a problem
for all artifacts since none of them have unique keys associated with them
unless an intermediary resolves the artifact immediately and possibly "renames"
the contents to make it unique.
If we ever want to support multiple layers of expansion for XLang we'll want
to proxy any artifact resolution/retrieval calls through the layers.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 415280)
Time Spent: 4.5h (was: 4h 20m)
> Enumerating artifacts is too expensive in Java
> ----------------------------------------------
>
> Key: BEAM-9578
> URL: https://issues.apache.org/jira/browse/BEAM-9578
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Heejong Lee
> Priority: Critical
> Labels: portability
> Fix For: 2.21.0
>
> Time Spent: 4.5h
> Remaining Estimate: 0h
>
> There are a lot of places (e.g. *ParDoTranslation#getParDoPayload*) which
> effectively call *Environments#createOrGetDefaultEnvironment* which causes
> [artifacts to be
> computed|https://github.com/apache/beam/blob/fc6cef9972780ca6b7525d4aadd65a8344221f1b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java#L114].
> This leads to zipping directories for non-jar dependencies.
> Similar problems may exist for Python/Go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
