[ 
https://issues.apache.org/jira/browse/BEAM-7505?focusedWorklogId=415340&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-415340
 ]

ASF GitHub Bot logged work on BEAM-7505:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 03/Apr/20 07:00
            Start Date: 03/Apr/20 07:00
    Worklog Time Spent: 10m 
      Work Description: pawelpasterz commented on pull request #11236: 
[BEAM-7505] Create SideInput Python Jenkins jobs
URL: https://github.com/apache/beam/pull/11236#discussion_r402770026
 
 

 ##########
 File path: .test-infra/jenkins/LoadTestConfig.groovy
 ##########
 @@ -202,6 +201,20 @@ class LoadTestConfig implements 
SerializableOption<Map<String, Serializable>> {
         return ConfigHelper.convertProperties(config.propertiesMap)
     }
 
+    /**
+     * Extends LoadTestConfig object by appending the given settings
+     * @param templateConfig LoadTestConfig instance
+     * @param cl Closure with settings
+     * @return LoadTestConfig object
+     */
+    static LoadTestConfig extend(final LoadTestConfig templateConfig, final 
Closure cl = {}) {
 
 Review comment:
   I am wondering if we should rename this method so its name would tell us 
what is being extended. Just thinking
 
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
[email protected]


Issue Time Tracking
-------------------

    Worklog Id:     (was: 415340)
    Time Spent: 4h 20m  (was: 4h 10m)

> Create SideInput Python Load Test Jenkins Job
> ---------------------------------------------
>
>                 Key: BEAM-7505
>                 URL: https://issues.apache.org/jira/browse/BEAM-7505
>             Project: Beam
>          Issue Type: Sub-task
>          Components: testing
>            Reporter: Kasia Kucharczyk
>            Assignee: Kamil Wasilewski
>            Priority: Major
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>




--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to