[
https://issues.apache.org/jira/browse/BEAM-9703?focusedWorklogId=416769&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-416769
]
ASF GitHub Bot logged work on BEAM-9703:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 17:03
Start Date: 06/Apr/20 17:03
Worklog Time Spent: 10m
Work Description: lukecwik commented on pull request #11319:
[BEAM-9703]Include user distritribution into metric-dedicated validate runner
test.
URL: https://github.com/apache/beam/pull/11319#discussion_r404247965
##########
File path: sdks/python/apache_beam/metrics/metric_test.py
##########
@@ -162,6 +169,17 @@ def process(self, element):
outputs_counter.key.metric.name, 'metrics_user_counter_element')
self.assertEqual(outputs_counter.committed, 4)
+ # Verify user distribution counter.
+ metric_results = res.metrics().query()
+ namespace = 'apache_beam.metrics.metric_test.SomeDoFn'
+ hc.assert_that(
+ metric_results['distributions'],
+ hc.contains_inanyorder(
+ MetricResult(
+ MetricKey('ApplyPardo', MetricName(namespace, 'element_dist')),
+ DistributionResult(DistributionData(10, 4, 1, 4)),
+ DistributionResult(DistributionData(10, 4, 1, 4)))))
Review comment:
not all runners support attempted metrics, please only compare against
committed metrics for now
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 416769)
Time Spent: 40m (was: 0.5h)
> Create py validations runner test for metrics
> ---------------------------------------------
>
> Key: BEAM-9703
> URL: https://issues.apache.org/jira/browse/BEAM-9703
> Project: Beam
> Issue Type: Bug
> Components: testing
> Reporter: Ruoyun Huang
> Assignee: Ruoyun Huang
> Priority: Minor
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Some of the metrics are not covered by dedicated validation runner test.
> Would like create these if needed.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
