[
https://issues.apache.org/jira/browse/BEAM-9468?focusedWorklogId=417080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-417080
]
ASF GitHub Bot logged work on BEAM-9468:
----------------------------------------
Author: ASF GitHub Bot
Created on: 06/Apr/20 20:13
Start Date: 06/Apr/20 20:13
Worklog Time Spent: 10m
Work Description: pabloem commented on pull request #11151: [BEAM-9468]
Hl7v2 io
URL: https://github.com/apache/beam/pull/11151#discussion_r404334588
##########
File path:
sdks/java/io/google-cloud-platform/src/main/java/org/apache/beam/sdk/io/gcp/healthcare/HealthcareIOErrorCoder.java
##########
@@ -0,0 +1,54 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements. See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership. The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.beam.sdk.io.gcp.healthcare;
+
+import java.io.IOException;
+import java.io.InputStream;
+import java.io.OutputStream;
+import org.apache.beam.sdk.coders.Coder;
+import org.apache.beam.sdk.coders.CoderException;
+import org.apache.beam.sdk.coders.CustomCoder;
+import org.apache.beam.sdk.coders.NullableCoder;
+import org.apache.beam.sdk.coders.StringUtf8Coder;
+
+public class HealthcareIOErrorCoder<T> extends
CustomCoder<HealthcareIOError<T>> {
+ private final Coder<T> originalCoder;
+ private static final NullableCoder<String> STRING_CODER =
NullableCoder.of(StringUtf8Coder.of());
+
+ HealthcareIOErrorCoder(Coder<T> originalCoder) {
+ this.originalCoder = NullableCoder.of(originalCoder);
+ }
+
+ @Override
+ public void encode(HealthcareIOError<T> value, OutputStream outStream)
+ throws CoderException, IOException {
+
+ originalCoder.encode(value.getDataResource(), outStream);
+
Review comment:
I see the observedTime is not serialized/deserialized. This means that the
observedTime for a HealthcareIOError event will keep changing as the event is
serialized / deserialized. Though I guess it will be roughly accurate when it's
written out. WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 417080)
Time Spent: 9.5h (was: 9h 20m)
> Add Google Cloud Healthcare API IO Connectors
> ---------------------------------------------
>
> Key: BEAM-9468
> URL: https://issues.apache.org/jira/browse/BEAM-9468
> Project: Beam
> Issue Type: New Feature
> Components: io-java-gcp
> Reporter: Jacob Ferriero
> Assignee: Jacob Ferriero
> Priority: Minor
> Time Spent: 9.5h
> Remaining Estimate: 0h
>
> Add IO Transforms for the HL7v2, FHIR and DICOM stores in the [Google Cloud
> Healthcare API|https://cloud.google.com/healthcare/docs/]
> HL7v2IO
> FHIRIO
> DICOM
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
