[
https://issues.apache.org/jira/browse/BEAM-9578?focusedWorklogId=418009&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418009
]
ASF GitHub Bot logged work on BEAM-9578:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/20 21:56
Start Date: 07/Apr/20 21:56
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11205: [BEAM-9578]
Enumerating artifacts is too expensive in Java
URL: https://github.com/apache/beam/pull/11205#discussion_r405136418
##########
File path:
runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java
##########
@@ -207,31 +210,94 @@ public static Environment createProcessEnvironment(
}
}
- public static Collection<ArtifactInformation> getArtifacts(PipelineOptions
options) {
- Set<String> pathsToStage = Sets.newHashSet();
- List<String> stagingFiles =
options.as(PortablePipelineOptions.class).getFilesToStage();
- if (stagingFiles != null) {
- pathsToStage.addAll(stagingFiles);
- }
-
- ImmutableList.Builder<ArtifactInformation> filesToStage =
ImmutableList.builder();
+ private static List<ArtifactInformation> getArtifacts(List<String>
stagingFiles) {
+ Set<String> pathsToStage = Sets.newHashSet(stagingFiles);
+ ImmutableList.Builder<ArtifactInformation> artifactsBuilder =
ImmutableList.builder();
for (String path : pathsToStage) {
File file = new File(path);
- if (new File(path).exists()) {
- // Spurious items get added to the classpath. Filter by just those
that exist.
+ // Spurious items get added to the classpath. Filter by just those that
exist.
+ if (file.exists()) {
+ ArtifactInformation.Builder artifactBuilder =
ArtifactInformation.newBuilder();
+
artifactBuilder.setTypeUrn(BeamUrns.getUrn(StandardArtifacts.Types.FILE));
+
artifactBuilder.setRoleUrn(BeamUrns.getUrn(StandardArtifacts.Roles.STAGING_TO));
+ artifactBuilder.setRolePayload(
+ RunnerApi.ArtifactStagingToRolePayload.newBuilder()
+ .setStagedName(createStagingFileName(file))
+ .build()
+ .toByteString());
if (file.isDirectory()) {
- // Zip up directories so we can upload them to the artifact service.
+ File zippedFile;
+ HashCode hashCode;
try {
- filesToStage.add(createArtifactInformation(zipDirectory(file)));
+ zippedFile = zipDirectory(file);
+ hashCode = Files.asByteSource(zippedFile).hash(Hashing.sha256());
} catch (IOException e) {
throw new RuntimeException(e);
}
+ artifactsBuilder.add(
+ artifactBuilder
+ .setTypePayload(
+ RunnerApi.ArtifactFilePayload.newBuilder()
+ .setPath(zippedFile.getPath())
+ .setSha256(hashCode.toString())
+ .build()
+ .toByteString())
+ .build());
} else {
- filesToStage.add(createArtifactInformation(file));
+ HashCode hashCode;
+ try {
+ hashCode = Files.asByteSource(file).hash(Hashing.sha256());
+ } catch (IOException e) {
+ throw new RuntimeException(e);
Review comment:
Or would it be better to let the method throw an IOException?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418009)
Time Spent: 8h (was: 7h 50m)
> Enumerating artifacts is too expensive in Java
> ----------------------------------------------
>
> Key: BEAM-9578
> URL: https://issues.apache.org/jira/browse/BEAM-9578
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core
> Reporter: Luke Cwik
> Assignee: Heejong Lee
> Priority: Critical
> Labels: portability
> Fix For: 2.21.0
>
> Time Spent: 8h
> Remaining Estimate: 0h
>
> There are a lot of places (e.g. *ParDoTranslation#getParDoPayload*) which
> effectively call *Environments#createOrGetDefaultEnvironment* which causes
> [artifacts to be
> computed|https://github.com/apache/beam/blob/fc6cef9972780ca6b7525d4aadd65a8344221f1b/runners/core-construction-java/src/main/java/org/apache/beam/runners/core/construction/Environments.java#L114].
> This leads to zipping directories for non-jar dependencies.
> Similar problems may exist for Python/Go.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
