[
https://issues.apache.org/jira/browse/BEAM-9577?focusedWorklogId=418047&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-418047
]
ASF GitHub Bot logged work on BEAM-9577:
----------------------------------------
Author: ASF GitHub Bot
Created on: 07/Apr/20 22:42
Start Date: 07/Apr/20 22:42
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11312: [BEAM-9577]
Plumb resources through Python job service and runner.
URL: https://github.com/apache/beam/pull/11312#discussion_r405155765
##########
File path:
sdks/python/apache_beam/runners/portability/fn_api_runner/fn_runner.py
##########
@@ -716,6 +716,15 @@ def __init__(self,
self.artifact_staging_dir = artifact_staging_dir
self.job_name = job_name
+ def for_environment(self, env):
+ if env.dependencies:
+ provision_info_with_deps = self.provision_info.copy()
+ provision_info_with_deps.dependencies = env.dependencies
+ return ExtendedProvisionInfo(
+ provision_info_with_deps, artifact_staging_dir, job_name)
Review comment:
Yeah...the tests weren't happy with this either :).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 418047)
Time Spent: 12h 50m (was: 12h 40m)
> Update artifact staging and retrieval protocols to be dependency aware.
> -----------------------------------------------------------------------
>
> Key: BEAM-9577
> URL: https://issues.apache.org/jira/browse/BEAM-9577
> Project: Beam
> Issue Type: Improvement
> Components: beam-model
> Reporter: Robert Bradshaw
> Assignee: Robert Bradshaw
> Priority: Major
> Time Spent: 12h 50m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
