[
https://issues.apache.org/jira/browse/BEAM-9648?focusedWorklogId=419032&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419032
]
ASF GitHub Bot logged work on BEAM-9648:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 00:24
Start Date: 09/Apr/20 00:24
Worklog Time Spent: 10m
Work Description: regadas commented on pull request #11275: [BEAM-9648]:
DirectRunner should return null on timeout
URL: https://github.com/apache/beam/pull/11275#discussion_r405889052
##########
File path:
runners/direct-java/src/main/java/org/apache/beam/runners/direct/ExecutorServiceParallelExecutor.java
##########
@@ -269,7 +277,7 @@ public State getPipelineState() {
}
private boolean isTerminalStateUpdate(VisibleExecutorUpdate update) {
- return !(update.getNewState() == null &&
update.getNewState().isTerminal());
+ return update.getNewState() != null && update.getNewState().isTerminal();
Review comment:
@lukecwik also found out that this conditional would throw an NPE
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419032)
Time Spent: 1h 10m (was: 1h)
> DirectRunner waitUntilFinish does not return null on timeout
> ------------------------------------------------------------
>
> Key: BEAM-9648
> URL: https://issues.apache.org/jira/browse/BEAM-9648
> Project: Beam
> Issue Type: Bug
> Components: runner-direct
> Affects Versions: 2.19.0
> Reporter: Filipe Regadas
> Assignee: Filipe Regadas
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> According to PipelineResult if waitUntilFinish(Duration) is supported it
> should return null.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
