[
https://issues.apache.org/jira/browse/BEAM-9726?focusedWorklogId=419588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419588
]
ASF GitHub Bot logged work on BEAM-9726:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 17:42
Start Date: 09/Apr/20 17:42
Worklog Time Spent: 10m
Work Description: ibzib commented on pull request #11353: [BEAM-9726]
Make region optional for non-service runner.
URL: https://github.com/apache/beam/pull/11353#discussion_r406369724
##########
File path:
runners/google-cloud-dataflow-java/src/main/java/org/apache/beam/runners/dataflow/DataflowRunner.java
##########
@@ -224,6 +225,9 @@
*/
public static final String PROJECT_ID_REGEXP = "[a-z][-a-z0-9:.]+[a-z0-9]";
+ /** Dataflow service endpoints are expected to match this pattern. */
+ static final String ENDPOINT_REGEXP = "https://[\\S]*googleapis\\.com[/]?";;
Review comment:
I copied this from the Python SDK, so I'm not sure what the source of truth
is. But a quick code search doesn't return any obvious negatives.
https://github.com/apache/beam/blob/ac003b6250f8b6e7dd8455fd5ffea7ded3b85bcd/sdks/python/apache_beam/options/pipeline_options_validator.py#L106
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419588)
Time Spent: 50m (was: 40m)
> Don't require --region for non-service Dataflow endpoints.
> ----------------------------------------------------------
>
> Key: BEAM-9726
> URL: https://issues.apache.org/jira/browse/BEAM-9726
> Project: Beam
> Issue Type: Bug
> Components: runner-dataflow
> Reporter: Kyle Weaver
> Assignee: Kyle Weaver
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 50m
> Remaining Estimate: 0h
>
> Some Dataflow internal tests don't run on the real Dataflow service. Since
> region only applies to the real Dataflow service, we should not require these
> tests to specify a region.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
