[
https://issues.apache.org/jira/browse/BEAM-9642?focusedWorklogId=419633&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419633
]
ASF GitHub Bot logged work on BEAM-9642:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 18:49
Start Date: 09/Apr/20 18:49
Worklog Time Spent: 10m
Work Description: lostluck commented on pull request #11327: [BEAM-9642]
Add SDF execution units.
URL: https://github.com/apache/beam/pull/11327#discussion_r405097712
##########
File path: sdks/go/pkg/beam/core/runtime/exec/pardo.go
##########
@@ -120,11 +120,17 @@ func (n *ParDo) ProcessElement(ctx context.Context, elm
*FullValue, values ...Re
if n.status != Active {
return errors.Errorf("invalid status for pardo %v: %v, want
Active", n.UID, n.status)
}
+
+ return n.ProcessMainInput(&MainInput{Key: *elm, Values: values})
+}
+
+func (n *ParDo) ProcessMainInput(mainIn *MainInput) error {
Review comment:
consider not exporting this, as it's helper function for ProcessElement for
the SDF components. Note that since they're in the same package, the unexported
methods could be used.
Regardless of if it's exported or not, please add a godoc comment why this
needs to be separated out.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419633)
Time Spent: 3h (was: 2h 50m)
> Add SDF execution-time runners
> ------------------------------
>
> Key: BEAM-9642
> URL: https://issues.apache.org/jira/browse/BEAM-9642
> Project: Beam
> Issue Type: Sub-task
> Components: sdk-go
> Reporter: Daniel Oliveira
> Assignee: Daniel Oliveira
> Priority: Major
> Time Spent: 3h
> Remaining Estimate: 0h
>
> Adds execution-time SDF runner units to the exec package, and any unit tests
> + helpers required.
> This is needed to get the expanded SDF URNs to execute in the runner harness.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
