[
https://issues.apache.org/jira/browse/BEAM-9562?focusedWorklogId=419755&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419755
]
ASF GitHub Bot logged work on BEAM-9562:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 21:01
Start Date: 09/Apr/20 21:01
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11314: [BEAM-9562]
Send Timers over Data Channel as Elements
URL: https://github.com/apache/beam/pull/11314#discussion_r406465514
##########
File path: sdks/python/apache_beam/runners/worker/bundle_processor.py
##########
@@ -837,25 +869,59 @@ def process_bundle(self, instruction_id):
op.execution_context = execution_context
op.start()
- # Inject inputs from data plane.
+ # Each data_channel is mapped to a list of expected inputs which includes
+ # both data input and timer input. The data input is identied by
+ # transform_id. The data input is identified by
+ # (transform_id, timer_family_id).
data_channels = collections.defaultdict(
list
) # type: DefaultDict[data_plane.GrpcClientDataChannel, List[str]]
+
+ # Inject data inputs from data plane.
Review comment:
This comment is a bit misleading, as the injection doesn't happen in this
for loop. (Similarly with timers.)
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419755)
Time Spent: 19h 10m (was: 19h)
> Remove timer from PCollection and treat timers as Elements
> -----------------------------------------------------------
>
> Key: BEAM-9562
> URL: https://issues.apache.org/jira/browse/BEAM-9562
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-harness, sdk-py-harness
> Reporter: Boyuan Zhang
> Assignee: Boyuan Zhang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 19h 10m
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
