[
https://issues.apache.org/jira/browse/BEAM-9136?focusedWorklogId=419813&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-419813
]
ASF GitHub Bot logged work on BEAM-9136:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Apr/20 22:01
Start Date: 09/Apr/20 22:01
Worklog Time Spent: 10m
Work Description: Hannah-Jiang commented on pull request #11243:
[BEAM-9136]Add licenses for dependencies for Java
URL: https://github.com/apache/beam/pull/11243#discussion_r406502326
##########
File path: sdks/java/container/build.gradle
##########
@@ -16,7 +16,11 @@
* limitations under the License.
*/
-plugins { id 'org.apache.beam.module' }
+plugins {
+ id 'org.apache.beam.module'
+ id 'com.github.jk1.dependency-license-report' version '1.13'
Review comment:
If I understand it correctly, dependencies without licenses/notice included
in jar are *considered* as the missing dependencies at first. However, the
reality is dependency scan is correct, it only missing licenses.
`com.github.jk1.dependency-license-report` generates `index.json` file as well,
which provides a list of all dependencies. I used this file to go through all
dependencies and pull licenses/notices if they are not pulled automatically.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 419813)
Time Spent: 20h 40m (was: 20.5h)
> Add LICENSES and NOTICES to docker images
> -----------------------------------------
>
> Key: BEAM-9136
> URL: https://issues.apache.org/jira/browse/BEAM-9136
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Hannah Jiang
> Assignee: Hannah Jiang
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 20h 40m
> Remaining Estimate: 0h
>
> Scan dependencies and add licenses and notices of the dependencies to SDK
> docker images.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
