[
https://issues.apache.org/jira/browse/BEAM-9735?focusedWorklogId=420521&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420521
]
ASF GitHub Bot logged work on BEAM-9735:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/20 21:32
Start Date: 10/Apr/20 21:32
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11365: [BEAM-9735]
Adding Always trigger and using it in Reshuffle
URL: https://github.com/apache/beam/pull/11365#discussion_r406952462
##########
File path: sdks/python/apache_beam/transforms/trigger.py
##########
@@ -367,6 +367,47 @@ def has_ontime_pane(self):
return False
+class Always(TriggerFn):
+ """Repeatedly invoke the given trigger, never finishing."""
+ def __init__(self):
+ pass
+
+ def __repr__(self):
+ return 'Always'
+
+ def __eq__(self, other):
+ return type(self) == type(other)
+
+ def __hash__(self):
+ return 1
Review comment:
More conventional is to return hash(type(self)), to avoid collisions, but
this is OK.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 420521)
Time Spent: 0.5h (was: 20m)
> Performance regression in Python Batch pipeline in Reshuffle
> ------------------------------------------------------------
>
> Key: BEAM-9735
> URL: https://issues.apache.org/jira/browse/BEAM-9735
> Project: Beam
> Issue Type: Bug
> Components: sdk-py-core
> Reporter: Ankur Goenka
> Assignee: Ankur Goenka
> Priority: Blocker
> Fix For: 2.21.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
