[
https://issues.apache.org/jira/browse/BEAM-9444?focusedWorklogId=420529&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-420529
]
ASF GitHub Bot logged work on BEAM-9444:
----------------------------------------
Author: ASF GitHub Bot
Created on: 10/Apr/20 21:36
Start Date: 10/Apr/20 21:36
Worklog Time Spent: 10m
Work Description: suztomo commented on pull request #11391: [BEAM-9444]
Rebasing old version of PR 11156 (no need to review)
URL: https://github.com/apache/beam/pull/11391
```
suztomo-macbookpro44% git log -3
commit b47744e6c69f5646a2c91026952aff65decc20b2 (HEAD ->
BEAM-9444-rebase-c00df443, suztomo/BEAM-9444-new, BEAM-9444-new)
Author: Tomo Suzuki <[email protected]>
Date: Fri Apr 10 17:03:21 2020 -0400
Applying difference
commit c17e7c9614fe181f33c93143ac760c0b7696622e (origin/master, origin/HEAD)
Merge: d5929ba273 81092b7134
Author: Pablo Estrada <[email protected]>
Date: Fri Apr 10 12:45:29 2020 -0700
Merge pull request #11383 from [BEAM-9736] Fix from_container_image call
[BEAM-9736] Fix from_container_image call
commit d5929ba2738b38e82f91038a541089a303161e34
Merge: 75433f0322 c26af84a24
Author: Robert Bradshaw <[email protected]>
Date: Fri Apr 10 12:44:38 2020 -0700
Merge pull request #11311 [BEAM-9577] Attempt to stage resources via new
API in portable runner.
suztomo-macbookpro44% git rebase c00df443f68efc643779fe13821c2cfdfea1f100
First, rewinding head to replay your work on top of it...
Applying: Update go protos.
Applying: [BEAM-9618] Pull bundle descriptors for Go.
Applying: [BEAM-9577] Plumb resources through Python job service and runner.
Applying: [BEAM-9529] Remove datastore.v1, googledatastore (#11175)
Applying: [BEAM-5422] Document DynamicDestinations.getTable uniqueness
requirement
Applying: [BEAM-9147] Add a VideoIntelligence transform to Java SDK (#11261)
Applying: [BEAM-9580] Allow Flink 1.10 processing timers to finish on
pipeline shutdown
Applying: Revert "[BEAM-9580] Downgrade Flink version to 1.9 for Nexmark and
ValidatesRunner"
Applying: [BEAM-9557] Fix strings used to verify test output
Applying: [BEAM-9714] [Go SDK] Require --region flag in Dataflow runner.
Applying: Update session.go
Applying: Update stage.go
Applying: Update server_test.go
Applying: Update materialize.go
Applying: Update materialize_test.go
Applying: Update stage_test.go
Applying: Update artifact.go
Applying: Update provision.go
Applying: Update retrieval.go
Applying: Update staging.go
Applying: Update translate.go
Applying: Update datamgr.go
Applying: Update datamgr_test.go
Applying: Update logging.go
Applying: Update logging_test.go
Applying: Update monitoring.go
Applying: Update session.go
Applying: Update statemgr.go
Applying: Update statemgr_test.go
Applying: Update replace.go
Applying: Update replace_test.go
Applying: Update provision.go
Applying: Update execute.go
Applying: Update job.go
Applying: Update translate.go
Applying: Update translate.go
Applying: Update job.go
Applying: Update materialize.go
Applying: Update translate.go
Applying: Update session.go
Applying: Update materialize_test.go
Applying: [BEAM-9596] Ensure metrics are available in PipelineResult when
the pipeline fails
Applying: Updates documentation for WINDOWED_VALUE coder.
Applying: Uses iterable coder for windows and copies all of timestamp
encoding specification.
Applying: Update session.go (#11352)
Applying: [BEAM-9322] [BEAM-1833] Better naming for composite transform
output tags.
Applying: [BEAM-9618] Java SDK worker support for pulling bundle
descriptors. (#11328)
Applying: [BEAM-9716] Alias zone to worker_zone and warn user.
Applying: [Beam-9063]update documentation (#10952)
Applying: Adds nose back under packages needed for testing.
Applying: [BEAM-9618] Mark push registration as deprecated.
Applying: Ensure that empty messages are not flushed to handler.
Applying: [BEAM-9721] Add --region to Dataflow-based load tests
Applying: [BEAM-9721] LoadTestConfig: handle --region parameter and put
default value if absent
Applying: [BEAM-9550] Increase JVM Metaspace size for the TaskExecutors.
(#11193)
Applying: [BEAM-9721]Conditionally add Dataflow region to Dataflow-based
performance tests (#11344)
Applying: [BEAM-9647] fixes MQTT clientId to long
Applying: [BEAM-8280] Document Python 3 annotations support (#11232)
Applying: [BEAM-9731] Include more detail in passert.Equals errors. (#11359)
Applying: [BEAM-9085] Fix performance regression in SyntheticSource on
Python 3 (#11092)
Applying: [BEAM-9726] [py] Make region optional for non-service Dataflow.
Applying: [BEAM-9726] [java] Make region optional for non-service runner.
Applying: [BEAM-4374] Fix missing deletion of metrics.
Applying: [BEAM-9651] Prevent StreamPool and stream initialization livelock
Applying: Revert "[BEAM-9651] Prevent StreamPool and stream initialization
livelock"
Applying: [BEAM-9727] Automatically set required experiment flags for
dataflow runner v2. (#11355)
Applying: Allow unset write threshold for state backed iterable coder.
Applying: [BEAM-9562, BEAM-6274] Fix-up timers to use Elements.Timer proto
in data channel in Beam Java and Python
Applying: Update environments.py to add a method to specify container image
(#11370)
Applying: add missing bracket
Applying: Moving to 2.22.0-SNAPSHOT on master branch.
Applying: [BEAM-9734] Revert #11122
Applying: [BEAM-9651] Prevent StreamPool and stream initialization livelock
Using index info to reconstruct a base tree...
M
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/DirectStreamObserver.java
M
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/ForwardingClientResponseObserver.java
M
runners/google-cloud-dataflow-java/worker/src/main/java/org/apache/beam/runners/dataflow/worker/windmill/WindmillServerStub.java
M
runners/google-cloud-dataflow-java/worker/src/test/java/org/apache/beam/runners/dataflow/worker/windmill/GrpcWindmillServerTest.java
Falling back to patching base and 3-way merge...
No changes -- Patch already applied.
Applying: Add --region to changelog
Applying: Upgrades gcsio to 2.1.2
Applying: Attempt to stage resources via new API in portable runner.
Applying: Fix from_container_image call
Applying: Applying difference
suztomo-macbookpro44% git log -3
commit d424ae027d7d15e11cc27b39fecbc3c834ea98db (HEAD ->
BEAM-9444-rebase-c00df443)
Author: Tomo Suzuki <[email protected]>
Date: Fri Apr 10 17:03:21 2020 -0400
Applying difference
commit 7388207f6ae55302a9c6060ab0ce441df81f7821
Author: Pablo Estrada <[email protected]>
Date: Fri Apr 10 12:08:34 2020 -0700
Fix from_container_image call
commit 9fb6ce64f892e21d47be89dd1a24a002da7dfb4b
Author: Robert Bradshaw <[email protected]>
Date: Thu Apr 2 13:03:03 2020 -0700
Attempt to stage resources via new API in portable runner.
```
------------------------
Thank you for your contribution! Follow this checklist to help us
incorporate your contribution quickly and easily:
- [ ] [**Choose
reviewer(s)**](https://beam.apache.org/contribute/#make-your-change) and
mention them in a comment (`R: @username`).
- [ ] Format the pull request title like `[BEAM-XXX] Fixes bug in
ApproximateQuantiles`, where you replace `BEAM-XXX` with the appropriate JIRA
issue, if applicable. This will automatically link the pull request to the
issue.
- [ ] Update `CHANGES.md` with noteworthy changes.
- [ ] If this contribution is large, please file an Apache [Individual
Contributor License Agreement](https://www.apache.org/licenses/icla.pdf).
See the [Contributor Guide](https://beam.apache.org/contribute) for more
tips on [how to make review process
smoother](https://beam.apache.org/contribute/#make-reviewers-job-easier).
Post-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
Lang | SDK | Apex | Dataflow | Flink | Gearpump | Samza | Spark
--- | --- | --- | --- | --- | --- | --- | ---
Go | [](https://builds.apache.org/job/beam_PostCommit_Go/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Flink/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Go_VR_Spark/lastCompletedBuild/)
Java | [](https://builds.apache.org/job/beam_PostCommit_Java/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Apex/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Dataflow_Java11/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Flink/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Flink_Streaming/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Gearpump/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Samza/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_Spark/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_PVR_Spark_Batch/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Java_ValidatesRunner_SparkStructuredStreaming/lastCompletedBuild/)
Python | [](https://builds.apache.org/job/beam_PostCommit_Python2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python36/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python37/lastCompletedBuild/)
| --- | [](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_VR_Dataflow_V2/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Py_ValCont/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PostCommit_Python35_VR_Flink/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_Python_VR_Spark/lastCompletedBuild/)
XLang | --- | --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Flink/lastCompletedBuild/)
| --- | --- | [](https://builds.apache.org/job/beam_PostCommit_XVR_Spark/lastCompletedBuild/)
Pre-Commit Tests Status (on master branch)
------------------------------------------------------------------------------------------------
--- |Java | Python | Go | Website
--- | --- | --- | --- | ---
Non-portable | [](https://builds.apache.org/job/beam_PreCommit_Java_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Python_Cron/lastCompletedBuild/)<br>[](https://builds.apache.org/job/beam_PreCommit_PythonLint_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Go_Cron/lastCompletedBuild/)
| [](https://builds.apache.org/job/beam_PreCommit_Website_Cron/lastCompletedBuild/)
Portable | --- | [](https://builds.apache.org/job/beam_PreCommit_Portable_Python_Cron/lastCompletedBuild/)
| --- | ---
See
[.test-infra/jenkins/README](https://github.com/apache/beam/blob/master/.test-infra/jenkins/README.md)
for trigger phrase, status and link of all Jenkins jobs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 420529)
Time Spent: 13h 10m (was: 13h)
> Shall we use GCP Libraries BOM to specify Google-related library versions?
> --------------------------------------------------------------------------
>
> Key: BEAM-9444
> URL: https://issues.apache.org/jira/browse/BEAM-9444
> Project: Beam
> Issue Type: Task
> Components: build-system
> Reporter: Tomo Suzuki
> Assignee: Tomo Suzuki
> Priority: Major
> Attachments: Screen Shot 2020-03-13 at 13.33.01.png, Screen Shot
> 2020-03-17 at 16.01.16.png
>
> Time Spent: 13h 10m
> Remaining Estimate: 0h
>
> Shall we use GCP Libraries BOM to specify Google-related library versions?
>
> I've been working on Beam's dependency upgrades in the past few months. I
> think it's time to consider a long-term solution to keep the libraries
> up-to-date with small maintenance effort. To achieve that, I propose Beam to
> use GCP Libraries BOM to set the Google-related library versions, rather than
> trying to make changes in each of ~30 Google libraries.
>
> h1. Background
> A BOM is pom.xml that provides dependencyManagement to importing projects.
>
> GCP Libraries BOM is a BOM that includes many Google Cloud related libraries
> + gRPC + protobuf. We (Google Cloud Java Diamond Dependency team) maintain
> the BOM so that the set of the libraries are compatible with each other.
>
> h1. Implementation
> Notes for obstacles.
> h2. BeamModulePlugin's "force" does not take BOM into account (thus fails)
> {{forcedModules}} via version resolution strategy is playing bad. This causes
> {noformat}
> A problem occurred evaluating project ':sdks:java:extensions:sql'.
> Could not resolve all dependencies for configuration
> ':sdks:java:extensions:sql:fmppTemplates'.
> Invalid format: 'com.google.cloud:google-cloud-core'. Group, name and version
> cannot be empty. Correct example: 'org.gradle:gradle-core:1.0'{noformat}
> !Screen Shot 2020-03-13 at 13.33.01.png|width=489,height=287!
>
> h2. :sdks:java:maven-archetypes:examples needs the version of
> google-http-client
> The task requires the version for the library:
> {code:java}
> 'google-http-client.version':
> dependencies.create(project.library.java.google_http_client).getVersion(),
> {code}
> This would generate NullPointerException. Running gradlew without the
> subproject:
>
> {code:java}
> ./gradlew -p sdks/java check -x :sdks:java:maven-archetypes:examples:check
> {code}
> h1. Problem in Gradle-generated pom files
> The generated Maven artifact POM has invalid data due to the BOM change. For
> example my locally installed
> {{~/.m2/repository/org/apache/beam/beam-sdks-java-io-google-cloud-platform/2.21.0-SNAPSHOT/beam-sdks-java-io-google-cloud-platform-2.21.0-SNAPSHOT.pom}}
> had the following problems.
> h2. The GCP Libraries BOM showing up in dependencies section:
> {noformat}
> <dependencies>
> <dependency>
> <groupId>com.google.cloud</groupId>
> <artifactId>libraries-bom</artifactId>
> <version>4.2.0</version>
> <scope>compile</scope>
> <exclusions>
> <exclusion>
> <groupId>com.google.guava</groupId>
> <artifactId>guava-jdk5</artifactId>
> </exclusion>...
> </exclusions>
> </dependency>
> {noformat}
> h2. The artifact that use the BOM in Gradle is missing version in the
> dependency.
> {noformat}
> <dependency>
> <groupId>com.google.api</groupId>
> <artifactId>gax</artifactId>
> <version/>
> <scope>compile</scope>
> ...
> </dependency>
> {noformat}
> h1. DependencyManagement section in generated pom.xml
> How can I check whether a entry in dependencies is "platform"?
> !Screen Shot 2020-03-17 at 16.01.16.png|width=504,height=344!
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
