[
https://issues.apache.org/jira/browse/BEAM-9733?focusedWorklogId=422242&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422242
]
ASF GitHub Bot logged work on BEAM-9733:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/20 19:09
Start Date: 14/Apr/20 19:09
Worklog Time Spent: 10m
Work Description: tweise commented on issue #11362: [BEAM-9733] Always
let ImpulseSourceFunction emit a final watermark
URL: https://github.com/apache/beam/pull/11362#issuecomment-613628419
> We have tests in `ExecutableStageDoFnOperatorTest`
(`outputsAreTaggedCorrectly`, `testEnsureDeferredStateCleanupTimerFiring`) and
through our integration tests. Admittedly, it would be good to dedicate a test
specifically to watermark behavior.
There is some coverage here:
https://github.com/apache/beam/blob/8db19a4645b8588ce9e046637b7619815169bdb1/runners/flink/src/test/java/org/apache/beam/runners/flink/translation/wrappers/streaming/ExecutableStageDoFnOperatorTest.java#L376
It covers only finish bundle on close though. But a similarly fine-grained
test should do (integration tests generally don't provide a signal for this).
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 422242)
Time Spent: 3h 20m (was: 3h 10m)
> ImpulseSourceFunction does not emit a final watermark
> -----------------------------------------------------
>
> Key: BEAM-9733
> URL: https://issues.apache.org/jira/browse/BEAM-9733
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Reporter: Maximilian Michels
> Assignee: Maximilian Michels
> Priority: Critical
> Fix For: 2.21.0
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> The Flink Runner's {{ImpulseSourceFunction}} does not emit a final watermark,
> unless {{--shutdownSourcesOnFinalWatermark}} flag has been specified (the
> flag is used in tests to shutdown the pipeline after reading all data). Most
> pipelines will be long-running and thus do not specify the flag.
> Not sending out the final watermark causes GroupByKey to hold back the data
> of event time windows until the pipeline is shut down (the final watermark is
> always emitted on pipeline shutdown which is why using the above flag works).
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
