[
https://issues.apache.org/jira/browse/BEAM-9692?focusedWorklogId=422371&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422371
]
ASF GitHub Bot logged work on BEAM-9692:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/20 22:00
Start Date: 14/Apr/20 22:00
Worklog Time Spent: 10m
Work Description: robertwb commented on pull request #11335: [BEAM-9692]:
Make CombineValues portable
URL: https://github.com/apache/beam/pull/11335#discussion_r408461679
##########
File path: sdks/python/apache_beam/runners/dataflow/dataflow_runner.py
##########
@@ -110,22 +110,27 @@ class DataflowRunner(PipelineRunner):
# Imported here to avoid circular dependencies.
# TODO: Remove the apache_beam.pipeline dependency in
CreatePTransformOverride
+ from apache_beam.runners.dataflow.ptransform_overrides import
CombineValuesPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
CreatePTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
ReadPTransformOverride
from apache_beam.runners.dataflow.ptransform_overrides import
JrhReadPTransformOverride
- _PTRANSFORM_OVERRIDES = [] # type: List[PTransformOverride]
+ # Thesse overrides should be applied before the proto representation of the
+ # graph is created.
+ _PTRANSFORM_OVERRIDES = [
+ CombineValuesPTransformOverride()
Review comment:
I suppose this is fine; it's just preserving an inconsistency in Dataflow
vs. everything else.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 422371)
Time Spent: 1.5h (was: 1h 20m)
> Clean Python DataflowRunner to use portable pipelines
> -----------------------------------------------------
>
> Key: BEAM-9692
> URL: https://issues.apache.org/jira/browse/BEAM-9692
> Project: Beam
> Issue Type: Improvement
> Components: runner-dataflow
> Reporter: Sam Rohde
> Assignee: Sam Rohde
> Priority: Major
> Time Spent: 1.5h
> Remaining Estimate: 0h
>
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
