[
https://issues.apache.org/jira/browse/BEAM-5605?focusedWorklogId=422408&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-422408
]
ASF GitHub Bot logged work on BEAM-5605:
----------------------------------------
Author: ASF GitHub Bot
Created on: 14/Apr/20 22:53
Start Date: 14/Apr/20 22:53
Worklog Time Spent: 10m
Work Description: boyuanzz commented on pull request #11414: [BEAM-5605,
BEAM-2939] Add support for FnApiDoFnRunner to handle split calls.
URL: https://github.com/apache/beam/pull/11414#discussion_r408482142
##########
File path:
sdks/java/harness/src/main/java/org/apache/beam/fn/harness/FnApiDoFnRunner.java
##########
@@ -761,72 +795,111 @@ public void processElementForElementAndRestriction(
continue;
}
- // Make sure to get the output watermark before we split to ensure
that the lower bound
- // applies to both the primary and residual.
- KV<Instant, WatermarkEstimatorStateT> watermarkAndState =
- currentWatermarkEstimator.getWatermarkAndState();
- SplitResult<RestrictionT> result = currentTracker.trySplit(0);
+ // Attempt to checkpoint the current restriction.
+ HandlesSplits.SplitResult splitResult =
Review comment:
Why do we want to checkpoint after processElement finishing?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 422408)
Time Spent: 18h (was: 17h 50m)
> Support Portable SplittableDoFn for batch
> -----------------------------------------
>
> Key: BEAM-5605
> URL: https://issues.apache.org/jira/browse/BEAM-5605
> Project: Beam
> Issue Type: New Feature
> Components: sdk-java-core
> Reporter: Scott Wegner
> Assignee: Luke Cwik
> Priority: Major
> Labels: portability
> Time Spent: 18h
> Remaining Estimate: 0h
>
> Roll-up item tracking work towards supporting portable SplittableDoFn for
> batch
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
