[
https://issues.apache.org/jira/browse/BEAM-9764?focusedWorklogId=424350&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424350
]
ASF GitHub Bot logged work on BEAM-9764:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 18:55
Start Date: 17/Apr/20 18:55
Worklog Time Spent: 10m
Work Description: udim commented on pull request #11428: [BEAM-9764]
multi threading & check urls instead of pulling
URL: https://github.com/apache/beam/pull/11428#discussion_r410387421
##########
File path: sdks/java/container/license_scripts/license_script.sh
##########
@@ -25,15 +25,23 @@ pip install PyYAML==5.3
pip install tenacity==5.0.4
# pull licenses, notices and source code
-python sdks/java/container/license_scripts/pull_licenses_java.py
+if [ "$1" = 'true' ]; then
+ python sdks/java/container/license_scripts/pull_licenses_java.py
--pull_licenses
+else
+ python sdks/java/container/license_scripts/pull_licenses_java.py
+fi
pip uninstall -y beautifulsoup4
pip uninstall -y future
pip uninstall -y PyYAML
pip uninstall -y tenacity
mkdir sdks/java/container/third_party_licenses
-gzip -r java_third_party_licenses/*
-cp -r java_third_party_licenses/*.jar sdks/java/container/third_party_licenses/
-cp -r java_third_party_licenses/*.csv.gz
sdks/java/container/third_party_licenses/
+if [ "$1" = 'true' ]; then
+ cp -r java_third_party_licenses/*.jar
sdks/java/container/third_party_licenses/
+ cp -r java_third_party_licenses/*.csv
sdks/java/container/third_party_licenses/
+else
+ # create an empty file to aviod no file/dir existing error
Review comment:
```suggestion
# create an empty file to avoid no file/dir existing error
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424350)
Time Spent: 2h 10m (was: 2h)
> :sdks:java:container:generateThirdPartyLicenses failing
> -------------------------------------------------------
>
> Key: BEAM-9764
> URL: https://issues.apache.org/jira/browse/BEAM-9764
> Project: Beam
> Issue Type: Bug
> Components: sdk-java-core, test-failures
> Reporter: Udi Meiri
> Assignee: Hannah Jiang
> Priority: Major
> Time Spent: 2h 10m
> Remaining Estimate: 0h
>
> https://builds.apache.org/job/beam_PreCommit_Python2_PVR_Flink_Cron/774/console
> The traceback is interspersed with other logs:
> {code}
> Traceback (most recent call last):
> Successfully pulled
> java_third_party_licenses/protobuf-java-util-3.11.1.jar/LICENSE from
> https://opensource.org/licenses/BSD-3-Clause
> Successfully pulled java_third_party_licenses/protoc-3.11.0.jar/LICENSE from
> http://www.apache.org/licenses/LICENSE-2.0.txt
> File "sdks/java/container/license_scripts/pull_licenses_java.py", line 138,
> in <module>
> Successfully pulled java_third_party_licenses/protoc-3.11.1.jar/LICENSE from
> http://www.apache.org/licenses/LICENSE-2.0.txt
> license_url = dep['moduleLicenseUrl']
> Successfully pulled java_third_party_licenses/zetasketch-0.1.0.jar/LICENSE
> from http://www.apache.org/licenses/LICENSE-2.0.txt
> KeyError: 'moduleLicenseUrl'
> {code}
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
