[
https://issues.apache.org/jira/browse/BEAM-9147?focusedWorklogId=424428&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-424428
]
ASF GitHub Bot logged work on BEAM-9147:
----------------------------------------
Author: ASF GitHub Bot
Created on: 17/Apr/20 21:06
Start Date: 17/Apr/20 21:06
Worklog Time Spent: 10m
Work Description: jkff commented on issue #11261: [BEAM-9147] Add a
VideoIntelligence transform to Java SDK
URL: https://github.com/apache/beam/pull/11261#issuecomment-615463060
Hi!
Drive-by comment: in the current form this transform violates the
[PTransform Style
Guide](https://beam.apache.org/contribute/ptransform-style-guide/#exposing-a-ptransform-vs-something-else),
specifically, it exposes a set of `DoFn`s rather than exposing a set of
`PTransform`s.
There are several very compelling advantages to exposing `PTransform`s,
mainly, compatibility: once it's a `DoFn` and clients use it via `ParDo`, you
can never add anything else into it (e.g. a reshuffle) without breaking client
code - but you can change the internal implementation of a `PTransform` at
will. Many `PTransform`s that used to be `DoFn`s before that style guide was
created, eventually evolved to be more complex.
Could you consider restructuring it in a follow-up PR? A similar DoFn-like
PTransform you can take example from is
[Regex](https://github.com/apache/beam/blob/master/sdks/java/core/src/main/java/org/apache/beam/sdk/transforms/Regex.java).
Thanks!
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 424428)
Time Spent: 3h 40m (was: 3.5h)
> [Java] PTransform that integrates Video Intelligence functionality
> ------------------------------------------------------------------
>
> Key: BEAM-9147
> URL: https://issues.apache.org/jira/browse/BEAM-9147
> Project: Beam
> Issue Type: Sub-task
> Components: io-java-gcp
> Reporter: Kamil Wasilewski
> Assignee: Michał Walenia
> Priority: Major
> Fix For: 2.21.0
>
> Time Spent: 3h 40m
> Remaining Estimate: 0h
>
> The goal is to create a PTransform that integrates Google Cloud Video
> Intelligence functionality [1].
> The transform should be able to take both video GCS location or video data
> bytes as an input.
> A module with the transform should be put into _`sdks/java/extensions`_
> folder.
> [1] [https://cloud.google.com/video-intelligence/]
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
