[ 
https://issues.apache.org/jira/browse/BEAM-9797?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17088956#comment-17088956
 ] 

Udi Meiri commented on BEAM-9797:
---------------------------------

Another thing you can do in tox is specify the Python version, removing the 
need to check for versions in pull_licenses_java.py.

> license_script.sh calls pip install/uninstall in local env
> ----------------------------------------------------------
>
>                 Key: BEAM-9797
>                 URL: https://issues.apache.org/jira/browse/BEAM-9797
>             Project: Beam
>          Issue Type: Bug
>          Components: build-system
>            Reporter: Udi Meiri
>            Priority: Major
>
> File is: 
> https://github.com/apache/beam/blob/master/sdks/java/container/license_scripts/license_script.sh
> The problem is with the code that does pip install and uninstall.
> 1. It is not okay to modify the local environment.
> 2. Running this script in parallel with itself (on Jenkins) has a chance to 
> cause a race.
> The solution is to use a tox environment to run this script in. Tox will take 
> care of creating a virtualenv with the required dependencies.



--
This message was sent by Atlassian Jira
(v8.3.4#803005)

Reply via email to