[
https://issues.apache.org/jira/browse/BEAM-9794?focusedWorklogId=426079&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426079
]
ASF GitHub Bot logged work on BEAM-9794:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/20 09:26
Start Date: 22/Apr/20 09:26
Worklog Time Spent: 10m
Work Description: mxm commented on a change in pull request #11478:
URL: https://github.com/apache/beam/pull/11478#discussion_r412821901
##########
File path:
runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferingDoFnRunner.java
##########
@@ -143,15 +174,15 @@ public void checkpoint(long checkpointId) throws
Exception {
// We are about to get checkpointed. The elements buffered thus far
// have to be added to the global CheckpointElement state which will
// be used to emit elements later when this checkpoint is acknowledged.
- addToBeAcknowledgedCheckpoint(checkpointId, currentStateId);
- currentStateId = generateNewId();
- currentBufferingElementsHandler =
bufferingElementsHandlerFactory.get(currentStateId);
+ addToBeAcknowledgedCheckpoint(checkpointId, getStateIndex());
+ int newStateIndex = rotateAndGetStateIndex();
+ currentBufferingElementsHandler =
bufferingElementsHandlerFactory.get(newStateIndex);
}
/** Should be called when a checkpoint is completed. */
public void checkpointCompleted(long checkpointId) throws Exception {
Review comment:
I wonder whether we should make the flushing backwards-compatible for
users who want to migrate.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426079)
Time Spent: 1h 10m (was: 1h)
> Flink pipeline with RequiresStableInput fails after Short.MAX_VALUE
> checkpoints.
> --------------------------------------------------------------------------------
>
> Key: BEAM-9794
> URL: https://issues.apache.org/jira/browse/BEAM-9794
> Project: Beam
> Issue Type: Bug
> Components: runner-flink
> Affects Versions: 2.14.0, 2.15.0, 2.16.0, 2.17.0, 2.18.0, 2.19.0, 2.20.0
> Reporter: David Morávek
> Assignee: Maximilian Michels
> Priority: Major
> Time Spent: 1h 10m
> Remaining Estimate: 0h
>
> Full original report:
> https://lists.apache.org/thread.html/rb2ebfad16d85bcf668978b3defd442feda0903c20db29c323497a672%40%3Cuser.beam.apache.org%3E
> The exception comes from:
> https://github.com/apache/flink/blob/release-1.8.0/flink-runtime/src/main/java/org/apache/flink/runtime/state/OperatorBackendSerializationProxy.java#L68
> In the Flink Runner code, each checkpoint results in a new OperatorState (or
> KeyedState if the stream is keyed):
> https://github.com/apache/beam/blob/v2.14.0/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferingDoFnRunner.java#L91-L103
> https://github.com/apache/beam/blob/v2.14.0/runners/flink/src/main/java/org/apache/beam/runners/flink/translation/wrappers/streaming/stableinput/BufferingDoFnRunner.java#L136-L143
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
