[
https://issues.apache.org/jira/browse/BEAM-5192?focusedWorklogId=426199&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-426199
]
ASF GitHub Bot logged work on BEAM-5192:
----------------------------------------
Author: ASF GitHub Bot
Created on: 22/Apr/20 15:56
Start Date: 22/Apr/20 15:56
Worklog Time Spent: 10m
Work Description: hermes85pl commented on a change in pull request #10433:
URL: https://github.com/apache/beam/pull/10433#discussion_r413106543
##########
File path:
sdks/java/io/elasticsearch/src/main/java/org/apache/beam/sdk/io/elasticsearch/ElasticsearchIO.java
##########
@@ -1317,8 +1341,10 @@ private String getDocumentMetadata(String document)
throws IOException {
spec.getTypeFn() != null ?
spec.getTypeFn().apply(parsedDocument) : null,
spec.getIdFn() != null ?
spec.getIdFn().apply(parsedDocument) : null,
spec.getUsePartialUpdate() ? DEFAULT_RETRY_ON_CONFLICT :
null);
+ SimpleModule module = new SimpleModule();
+ module.addSerializer(DocumentMetadata.class, new
DocumentMetadataSerializer());
+ OBJECT_MAPPER.registerModule(module);
Review comment:
This shouldn't be done **here**, should it?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 426199)
Time Spent: 2h 40m (was: 2.5h)
> Support Elasticsearch 7.x
> -------------------------
>
> Key: BEAM-5192
> URL: https://issues.apache.org/jira/browse/BEAM-5192
> Project: Beam
> Issue Type: Improvement
> Components: io-java-elasticsearch
> Reporter: Etienne Chauchot
> Assignee: Etienne Chauchot
> Priority: Major
> Fix For: 2.19.0
>
> Time Spent: 2h 40m
> Remaining Estimate: 0h
>
> ES v7 is not out yet. But Elastic team scheduled a breaking change for ES
> 7.0: the removal of the type feature. See
> [https://www.elastic.co/blog/index-type-parent-child-join-now-future-in-elasticsearch]
> This will require a good amont of changes in the IO.
> This ticket is there to track the future work.
--
This message was sent by Atlassian Jira
(v8.3.4#803005)
